lucene-solr icon indicating copy to clipboard operation
lucene-solr copied to clipboard

document merge-based approach to updating existing PRs

Open magibney opened this issue 4 years ago • 4 comments

magibney avatar Mar 18 '21 21:03 magibney

I will give this a test this evening.

epugh avatar Mar 18 '21 21:03 epugh

so this may make sense at the root of lucene-solr to catch eyes, however I'd be interested in the same information over in solr\dev_docs\ as well. Increase chances we find it in both places ;-)

epugh avatar Mar 18 '21 22:03 epugh

LGTM, did not test it..

janhoy avatar Mar 19 '21 12:03 janhoy

I'm inclined to leave this as-is for now (with the recent minor addition of the merge.renameLimit increase, which I think is probably mostly cosmetic wrt suppressing a warning that I think in this context is probably not significant? -- can't hurt, in any case). ... unless there are any modifications suggested.

My impression is that this is placed in the root of lucene-solr not so much to catch eyes as because this is really about the migration, for people who may still be looking mainly at the legacy joint project, and because it applies equally to Lucene- and Solr-focused PRs.

I could see placing a more general-purpose "guide to working with Solr PRs" markdown/adoc file in solr:solr/dev-docs, and maybe linking from there to this top-level legacy project "PR migration" readme? That way the content can be maintained in a single (most logical) place. However this is approached, perhaps it makes sense as a separate issue (in the new solr TLP)?

magibney avatar Mar 19 '21 17:03 magibney