logging-log4j2 icon indicating copy to clipboard operation
logging-log4j2 copied to clipboard

LOG4J2-3182 Protect KafkaManager against start failures upon config changes

Open wuqian0808 opened this issue 4 years ago • 4 comments

LOG4J2-3182 Protect KafkaManager against start failures upon config changes.

wuqian0808 avatar Nov 09 '21 03:11 wuqian0808

@garydgregory Raise new clean PR instead. Add all modifications

wuqian0808 avatar Nov 09 '21 03:11 wuqian0808

This PR supersedes #593.

vy avatar Nov 09 '21 08:11 vy

a little confused by the title of this PR. It mentions protecting Kafk

Actually if the log4j2 configuration starts failed and with monitorinterval set. The scheduled thread will always increase. I just changed this tittle as requested. But this thread leak logic will affect all.

wuqian0808 avatar Nov 22 '21 09:11 wuqian0808

@vy makes a very important point here that I would like to emphasize: if your test passes without the changes to the main tree, then your test does not prove that you've fixed anything.

garydgregory avatar Nov 24 '21 13:11 garydgregory