Enable to specify port in OpenStack ex_attach_floating_ip_to_node #2027

[micafer]

trafficstars

Enable to specify port in OpenStack ex_attach_floating_ip_to_node

Description

Enable to specify port in OpenStack ex_attach_floating_ip_to_node #2027

Status

Replace this: describe the PR status. Examples:

• done, ready for review

Checklist (tick everything that applies)

• [x] Code linting (required, can be done after the PR checks)
• [ ] Documentation
• [x] Tests
• [ ] ICLA (required for bigger changes)

[codecov-commenter]

Codecov Report

:x: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 83.39%. Comparing base (8f3d0b4) to head (616cf5c). :warning: Report is 12 commits behind head on trunk.

Files with missing lines	Patch %	Lines
libcloud/compute/drivers/openstack.py	16.67%	3 Missing and 2 partials :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk    #2028      +/-   ##
==========================================
- Coverage   83.40%   83.39%   -0.01%     
==========================================
  Files         353      353              
  Lines       81685    81696      +11     
  Branches     8632     8634       +2     
==========================================
- Hits        68124    68123       -1     
- Misses      10738    10750      +12     
  Partials     2823     2823              

Files with missing lines	Coverage Δ
libcloud/test/compute/test_openstack.py	94.50% <100.00%> (-0.08%)	:arrow_down:
libcloud/compute/drivers/openstack.py	84.34% <16.67%> (-0.65%)	:arrow_down:

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[micafer]

Hi @Kami,

Did you have time to review this? There are no new releases of libcloud for a long time, is there any problem?

Best regards.

[Kami]

@mcalmer Sorry for the delay - it has now been reviewed.