kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

kyuubi-sparksql support hive-udf permission control

Open liujinhui1994 opened this issue 7 months ago • 7 comments

Why are the changes needed?

kyuubi-sparksql, supports UDF permission control

How was this patch tested?

We have already run it in production without any problems, and solved the problem of controlling the permissions used by our UDF.

Was this patch authored or co-authored using generative AI tooling?

NO

liujinhui1994 avatar Apr 15 '25 09:04 liujinhui1994

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (647a713) to head (982803a). Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
.../kyuubi/plugin/spark/authz/PrivilegesBuilder.scala 0.00% 25 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #7024    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         694     696     +2     
  Lines       42768   43042   +274     
  Branches     5821    5858    +37     
=======================================
- Misses      42768   43042   +274     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Apr 15 '25 21:04 codecov-commenter

FYI: You can run dev/reformat to refine the style.

turboFei avatar Apr 24 '25 22:04 turboFei

@turboFei please review thanks

liujinhui1994 avatar May 12 '25 02:05 liujinhui1994

@liujinhui1994 any chance to supply a unit test to cover your changes, to avoid being broken accidentally in the future?

pan3793 avatar May 12 '25 02:05 pan3793

after a closer look at the code, the direction might be incorrect, there is an existing FunctionExtractor that supports extracting Hive UDFs, but seems was not applied properly for commands and queries.

pan3793 avatar May 12 '25 03:05 pan3793

@liujinhui1994 any chance to supply a unit test to cover your changes, to avoid being broken accidentally in the future? ok

liujinhui1994 avatar May 12 '25 03:05 liujinhui1994

Please take a look. Any other questions? @pan3793

liujinhui1994 avatar May 19 '25 05:05 liujinhui1994

Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!

Thank you for using Kyuubi!

github-actions[bot] avatar Sep 04 '25 00:09 github-actions[bot]