[KYUUBI #6689] Extract kyuubiClientPrincipal/kyuubiClientKeytab from JDBC connection properties

[Madhukar525722]

trafficstars

…ab from JDBC connection properties

:mag: Description

Issue References 🔗

This pull request fixes #6689

Describe Your Solution 🔧

It extracts the value AUTH_KYUUBI_CLIENT_PRINCIPAL and AUTH_KYUUBI_CLIENT_KEYTAB, then passes it to connParams , to be used for establishing connections.

Types of changes :bookmark:

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

---

Checklist 📝

• [ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (550f1fc) to head (062cd08). Report is 109 commits behind head on master.

Files with missing lines	Patch %	Lines
...c/main/java/org/apache/kyuubi/jdbc/hive/Utils.java	0.00%	18 Missing :warning:

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #6693     +/-   ##
========================================
  Coverage    0.00%   0.00%             
========================================
  Files         684     688      +4     
  Lines       42237   44129   +1892     
  Branches     5755    6077    +322     
========================================
- Misses      42237   44129   +1892     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[wForget]

and cc @pan3793

[Madhukar525722]

Hi @pan3793 , Please review the change

[pan3793]

what about kyuubiServerPrincipal and pricipal?

[Madhukar525722]

Hi @pan3793, Actually the need for kyuubiServerPrincipal was not mentioned in the issue. I will be adding it as well, soon. cc @wForget

[wForget]

what about kyuubiServerPrincipal and pricipal?

My original intention was to pass in the client's authentication information in properties. kyuubiServerPrincipal can be provided by zk and we don't need to get it here.

[pan3793]

kyuubiServerPrincipal can be provided by zk

this is disabled by default, because the lower Hive client does not support parsing that.

It would be weird if kyuubiClientPrincipal works but kyuubiServerPrincipal does not. Let's keep them synced to avoid surprising users.

[Madhukar525722]

Hi @pan3793 , I have updated the required. Please review

[Madhukar525722]

HI @pan3793, Gentle ping

[pan3793]

LGTM, thank you, @Madhukar525722, please update the PR title and desc to match the code

[Madhukar525722]

HI @pan3793, I have changed as suggested.

[github-actions[bot]]

Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!

Thank you for using Kyuubi!

[github-actions[bot]]

Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!

Thank you for using Kyuubi!