kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #6615] Make Jetty sending server version in response configurable

Open paul8263 opened this issue 1 year ago โ€ข 1 comments

:mag: Description

Issue References ๐Ÿ”—

This pull request fixes #6615

Describe Your Solution ๐Ÿ”ง

Add a config item that controls whether Jetty should send its version in response.

This is an additional patch which enables/disables sending Jetty version for prometheus reporter.

Sending Jetty version could be disabled by calling HttpConfiguration::setSendServerVersion(false)

Types of changes :bookmark:

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan ๐Ÿงช

Compiled and tested manually.

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests


Checklist ๐Ÿ“

Be nice. Be informative.

paul8263 avatar Sep 11 '24 10:09 paul8263

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (edbe3f3) to head (0638a51). Report is 92 commits behind head on master.

Files with missing lines Patch % Lines
...che/kyuubi/metrics/PrometheusReporterService.scala 0.00% 11 Missing :warning:
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6685   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42237   42247   +10     
  Branches     5755    5755           
======================================
- Misses      42237   42247   +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 11 '24 11:09 codecov-commenter

Sorry missing this PR, merged to master

pan3793 avatar Dec 24 '24 13:12 pan3793

Sorry missing this PR, merged to master

Thanks bro.

paul8263 avatar Dec 30 '24 02:12 paul8263