kyuubi
kyuubi copied to clipboard
[KYUUBI #6619][FOLLOWUP] Do not log auth audit log for thrift http cookie auth
:mag: Description
Issue References ๐
Follow up for #6619, I found that, there are many duplicate auth audit logs for thrift http.
We shall only log when make authentication with auth handler, and skip it for cookie auth.
Describe Your Solution ๐ง
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Test Plan ๐งช
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests
Checklist ๐
- [ ] This patch was not authored or co-authored using Generative Tooling
Be nice. Be informative.
Codecov Report
Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
705bb2a) to head (3a25a3d). Report is 12 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| .../apache/kyuubi/server/http/ThriftHttpServlet.scala | 0.00% | 7 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #6632 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 680 680
Lines 42045 42049 +4
Branches 5739 5740 +1
======================================
- Misses 42045 42049 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
thanks, merged to 1.10.0