kylin icon indicating copy to clipboard operation
kylin copied to clipboard

KYLIN-3561 Migrate core modules to Junit 5

Open andreoss opened this issue 3 years ago • 3 comments

Proposed changes

https://issues.apache.org/jira/projects/KYLIN/issues/KYLIN-3561

Partial migration to Junit 5, changes to core* modules.

Branch to commit

  • [ ] Branch kylin3 for v2.x to v3.x
  • [ ] Branch kylin4 for v4.x
  • [ ] Branch kylin5 for v5.x

Types of changes

What types of changes does your code introduce to Kylin? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] I have created an issue on Kylin's jira, and have described the bug/feature there in detail
  • [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • [x] Compiling and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [x] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] or [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

andreoss avatar Oct 12 '22 23:10 andreoss

Hi, @andreoss , I am glad to see you propose this upgrade, here is my opinion.

  1. For JUnit 5, we already have do it in kylin5 branch, here is part of the code.
  2. main branch is for kylin 4.x, which community may not do much development work on this branch.

hit-lacus avatar Oct 13 '22 08:10 hit-lacus

@hit-lacus Thanks, I will rebase to kylin5 branch

andreoss avatar Oct 13 '22 13:10 andreoss

yes, i think this is done in kylin5 branch.

hit-lacus avatar Oct 14 '22 10:10 hit-lacus