kvrocks-controller icon indicating copy to clipboard operation
kvrocks-controller copied to clipboard

return new NodeID to avoid fetching it again when add new node to cluster

Open greatsharp opened this issue 6 months ago • 1 comments

greatsharp avatar May 10 '25 06:05 greatsharp

Snipaste_2025-05-10_14-18-21

greatsharp avatar May 10 '25 06:05 greatsharp

@greatsharp Would you mind adding a test case for this?

git-hulk avatar May 11 '25 11:05 git-hulk

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.66%. Comparing base (6c56470) to head (88e1305). Report is 69 commits behind head on unstable.

Files with missing lines Patch % Lines
store/cluster_shard.go 25.00% 3 Missing :warning:
store/cluster.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #307      +/-   ##
============================================
+ Coverage     43.38%   46.66%   +3.27%     
============================================
  Files            37       45       +8     
  Lines          2971     4391    +1420     
============================================
+ Hits           1289     2049     +760     
- Misses         1544     2134     +590     
- Partials        138      208      +70     
Flag Coverage Δ
unittests 46.66% <37.50%> (+3.27%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar May 11 '25 11:05 codecov-commenter

@greatsharp Would you mind adding a test case for this?

sure, wait for a moment please

greatsharp avatar May 12 '25 02:05 greatsharp

@greatsharp Would you mind adding a test case for this?

check again

greatsharp avatar May 12 '25 13:05 greatsharp