kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Published 20 hours ago • verified publisher icon apache

KAFKA-18209 Cleanup `__transaction_state` config logic

Open wernerdv opened this issue 11 months ago • 6 comments

Since the EnforcedCompression and EnforcedRequiredAcks fields are used only in the TransactionStateManager class, I moved them to a companion object.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

wernerdv avatar Dec 15 '24 15:12 wernerdv

A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the triage label should be removed to prevent this automation from happening again.

github-actions[bot] avatar Dec 23 '24 03:12 github-actions[bot]

@mimaison Can you tell me if there's anything I can do to improve my PR?

wernerdv avatar Jan 14 '25 13:01 wernerdv

A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the triage label should be removed to prevent this automation from happening again.

github-actions[bot] avatar Jan 16 '25 03:01 github-actions[bot]

When I opened the ticket I was hoping we could do a bit more cleanup, but maybe there isn't much to do. The point of the Jira was to investigate and see what could be done.

I left a couple of comments on the changes you propose.

@mimaison If there are any suggestions or comments, I am ready to address them. If this task is no longer relevant, we can close the PR and Jira.

wernerdv avatar Mar 12 '25 17:03 wernerdv

Thanks for the updates. As I said I was hoping for more cleanups but I think this still is a small improvement. I'm unsure where to put the EnforcedCompression and EnforcedRequiredAcks, and I'm wondering if keeping them in TransactionLog is the simplest option as moving them to TransactionCoordinator is not really helping.

mimaison avatar Mar 14 '25 15:03 mimaison

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Jun 13 '25 03:06 github-actions[bot]