KAFKA-17248 - KIP 1076 implementation

[bbejeck]

Implementation of KIP-1076 to allow for adding client application metrics to the KIP-714 framework

Integration and unit tests forthcoming

Committer Checklist (excluded from commit message)

• [ ] Verify design and implementation
• [ ] Verify test coverage and CI build status
• [ ] Verify documentation (including upgrade notes)

[bbejeck]

Thanks for the comments @apoorvmittal10 - I've addressed your comments.

[bbejeck]

should we also verify state store metrics (or are they automatically verified as part of task metrics)?

They are covered as part of task metrics, but I expanded the test to explicitly verify state store metrics are correct as well

[bbejeck]

@mjsax thanks for the second review, I've addressed your comments

[bbejeck]

@mjsax, @apoorvmittal10, @AndrewJSchofield comments addressed

[bbejeck]

@AndrewJSchofield, thanks for the review; I've addressed your comment.

[bbejeck]

@mjsax

Did not look at test code yet.

I've updated the integration test and I consider it completed at this point

[bbejeck]

should we extend the test, to not only verify task metrics, but also thread metrics? What about DEBUG and TRACE level?

Sure, but I don't think that should block the PR. Given that TRACE will include all metrics I'd say the end-to-end test should simply extend to set trace level to ensure all expected metrics make it through.

EDIT: I've updated the end-to-end test to include all expected metrics at the INFO, DEBUG, andTRACE levels.

[mjsax]

@bbejeck Can you rebase this PR to resolve merge conflicts?

[bbejeck]

@mjsax rebased on trunk - ready for final review

[bbejeck]

Merged #17021 into trunk