kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Published 20 hours ago • verified publisher icon apache

KAFKA-12827 Remove Deprecated method KafkaStreams#setUncaughtExceptionHandler

Open abhishekgiri23 opened this issue 1 year ago • 9 comments

  • Remove Deprecated method KafkaStreams#setUncaughtExceptionHandler
  • Fix test cases.
  • https://issues.apache.org/jira/browse/KAFKA-12827

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

abhishekgiri23 avatar Aug 23 '24 17:08 abhishekgiri23

Can someone from the committer's group trigger the build again? I ran the test cases locally and It went successful

CC @mjsax @jlprat

abhishekgiri23 avatar Aug 27 '24 10:08 abhishekgiri23

Hi @abhishekgiri23 We have some flaky tests and having a green build is not something that occurs that often unfortunately.

jlprat avatar Aug 27 '24 10:08 jlprat

@abhishekgiri23 -- Any updates on this PR?

mjsax avatar Sep 03 '24 23:09 mjsax

@abhishekgiri23 -- Any updates on this PR?

@mjsax was caught up in other stuff. I didn't have time to work on it. I am planning to update it by this weekend.

abhishekgiri23 avatar Sep 04 '24 11:09 abhishekgiri23

@abhishekgiri23 -- Seems you pushed some changes, but w/o addressing all review comments yet.

mjsax avatar Sep 15 '24 22:09 mjsax

@abhishekgiri23 -- Seems you pushed some changes, but w/o addressing all review comments yet.

It is still in progress.. will push and notify

abhishekgiri23 avatar Sep 16 '24 16:09 abhishekgiri23

@abhishekgiri23 -- How are things going?

mjsax avatar Oct 16 '24 21:10 mjsax

@mjsax only one class is remaining, I will fix it very soon. Please bear with me for being delayed.

abhishekgiri23 avatar Oct 18 '24 20:10 abhishekgiri23

No problem. Just checking in :) -- Btw: 335 commits does not sound right. Seems you need to cleanup this PR a little bit (it seems it needs a proper rebase on trunk)

mjsax avatar Oct 18 '24 22:10 mjsax

@abhishekgiri23 -- We are slowly approaching AK 4.0 release deadline. Would be great if we could finish this soon.

mjsax avatar Oct 30 '24 06:10 mjsax

Thanks for updating the PR. There is test errors:

FAILED ❌ EosIntegrationTest > "shouldNotViolateEosIfOneTaskFails(boolean).processingThreadsEnabled=true"
FAILED ❌ EosIntegrationTest > "shouldNotViolateEosIfOneTaskFails(boolean).processingThreadsEnabled=false"
FAILED ❌ EosIntegrationTest > "shouldNotViolateEosIfOneTaskFailsWithState(boolean).processingThreadsEnabled=true"
FAILED ❌ EosIntegrationTest > "shouldNotViolateEosIfOneTaskFailsWithState(boolean).processingThreadsEnabled=false"
FAILED ❌ QueryableStateIntegrationTest > shouldAllowToQueryAfterThreadDied()

mjsax avatar Oct 31 '24 00:10 mjsax

@abhishekgiri23 There is merge conflicts. Can you rebase to latest trunk?

mjsax avatar Nov 02 '24 00:11 mjsax

@abhishekgiri23 There is merge conflicts. Can you rebase to latest trunk?

it is interesting, I rebased it. But it is still not resolved. Let me check

abhishekgiri23 avatar Nov 02 '24 14:11 abhishekgiri23

Thanks for the PR! Merged to trunk.

mjsax avatar Nov 06 '24 06:11 mjsax