kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION

Open abhi-ksolves opened this issue 1 year ago • 8 comments

Deprecated Variable StreamsConfig#TOPOLOGY_OPTIMIZATION is removed

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

abhi-ksolves avatar Jul 31 '24 06:07 abhi-ksolves

I just checked the full repo, and also found TOPOLOGY_OPTIMIZATION mentioned in docs/streams/upgrade_guide.html -- I think we should update it there, too.

mjsax avatar Aug 01 '24 02:08 mjsax

I just checked the full repo, and also found TOPOLOGY_OPTIMIZATION mentioned in docs/streams/upgrade_guide.html -- I think we should update it there, too.

Yes, Mentioned changes are updated

abhi-ksolves avatar Aug 08 '24 06:08 abhi-ksolves

Hi @mjsax, Could you please review this PR? I attempted to rebase it, but now it contains too many commits. Should I close this PR and create a new one?

abhi-ksolves avatar Aug 09 '24 09:08 abhi-ksolves

Hi @mjsax can you please check & confirm?

abhi-ksolves avatar Aug 13 '24 10:08 abhi-ksolves

Not sure what happened to this PR, but it contains 45 commits and thoughts of LOC... Can you please cleanup the PR by rebasing it to latest trunk such that it only contains the relevant changes? And we can take it from there.

mjsax avatar Aug 23 '24 03:08 mjsax

Hi @mjsax these commits come from while doing rebasing itself. I will make new PR.

abhi-ksolves avatar Aug 28 '24 17:08 abhi-ksolves

Seems there is conflicts. Can you try again to rebase? (Did you create the new branch from latest trunk? Wondering why there are still conflicts...)

mjsax avatar Aug 29 '24 01:08 mjsax

@mjsax Conflicts resolved. Please review again

abhi-ksolves avatar Aug 29 '24 07:08 abhi-ksolves

Thanks for the PR! Merged to trunk.

mjsax avatar Aug 30 '24 01:08 mjsax