kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Published 20 hours ago • verified publisher icon apache

KAFKA-15739: KRaft support in ResetConsumerGroupOffsetTest

Open linzihao1999 opened this issue 2 years ago • 8 comments

The tests in ResetConsumerGroupOffsetTest in core/src/test/scala/unit/kafka/admin/ResetConsumerGroupOffsetTest.scala update to support KRaft.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

linzihao1999 avatar Nov 01 '23 14:11 linzihao1999

Hi @dengziming

I check this CI-builds and no failure report about ResetConsumerGroupOffsetTest. Should I trigger more times? PTAL, thanks!

https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14686/1/#showFailuresLink

linzihao1999 avatar Nov 11 '23 09:11 linzihao1999

Hi @linzihao1999 , Please merge trunk to trigger CI for more than 3 times to ensure there is no flaky.

dengziming avatar Dec 19 '23 11:12 dengziming

Hi @dengziming I trigger CI for 5 times and no flaky about it.

https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14686/8/pipeline https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14686/7/pipeline https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14686/6/pipeline https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14686/5/pipeline https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14686/4/pipeline

linzihao1999 avatar Dec 27 '23 02:12 linzihao1999

Thanks for the PR! We're half way through moving ConsumerGroupCommand (KAFKA-14589). It's probably best to finish the move before updating this test.

mimaison avatar Feb 02 '24 13:02 mimaison

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar May 05 '24 03:05 github-actions[bot]

@linzihao1999 ConsumerGroupCommand has now been rewritten in Java. Can you update this PR? Thanks

mimaison avatar May 13 '24 13:05 mimaison

@mimaison Sorry for stale this issue. I will fix it in this week. Fell free to take over if you have other arrangements.

linzihao1999 avatar May 13 '24 13:05 linzihao1999

Thanks for the update! This is not urgent, so it's ok if you can work on it in the next few weeks.

mimaison avatar May 13 '24 13:05 mimaison

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Jan 04 '25 03:01 github-actions[bot]

Done in https://github.com/apache/kafka/pull/15779, closing

mimaison avatar Jan 09 '25 14:01 mimaison