kafka
kafka copied to clipboard
apache
KAFKA-15143: Adding in MockFixedKeyProcessorContext and Test
This change is to introduce the MockFixedKeyProcessorContext, which extends the existing MockProcessorContext, and is essential when trying to test a FixedKeyProcessor in Unit Tests
Testing includes the MockFixedKeyProcessorContextTest which brings in the tests from MockProcessorContextAPITest however, adhering to fixed key processing (in every test, the key does not change)
Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
@s7pandey -- Thanks for this PR -- this is a public API change and thus we need a KIP for it. Not sure if you are familiar with the KIP process: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
Let us know if you have any questions about it. Happy to help getting the KIP approved and this PR merged.
Hey @mjsax, sounds good, I’ll get working on that, will reach out if I have any questions, thanks!
Hey @mjsax I seem unable to gain access to Confluence, following the instructions on the KIP page leads me to a page where I cannot sign up, would I need to follow: https://infra.apache.org/new-committers-guide.html#becoming-a-committer ? If so, I can submit the ICLA
That weird -- signup should just work. (You definitely don't need to file an ICLA or become a committer :)) -- Maybe it's a temporary glitch -- or something is broken and we need to file a ticket to get it fixed by the infra team (the wiki is for all Apache projects, not just for Kafka).
Can you maybe send an email [email protected] as suggested and ask? Feel free to add me as cc ([email protected]).