jackrabbit-oak icon indicating copy to clipboard operation
jackrabbit-oak copied to clipboard

OAK-9893 Prefetch for queries

Open thomasmueller opened this issue 3 years ago • 2 comments
trafficstars

Details are in https://issues.apache.org/jira/browse/OAK-9893

thomasmueller avatar Aug 09 '22 16:08 thomasmueller

I think we should also add a higher level test where we validate the result set of a few queries in case of prefetch enabled especially a case where the result set size would be greater than the prefetch count.

@nit0906 I have added the test you described now, and a few more. The code coverage of the PrefetchCursor was nearly 90% before these tests, and is now >90%. Actually I don't think the code coverage can be increased further in a reasonable way.

thomasmueller avatar Aug 10 '22 16:08 thomasmueller

I have added the test you described now, and a few more. The code coverage of the PrefetchCursor was nearly 90% before these tests, and is now >90%. Actually I don't think the code coverage can be increased further in a reasonable way.

@thomasmueller - Thanks. I was actually thinking on the lines of adding a test in oak-search where Oak might be initialised with system property to enable the prefetch feature for queries. But yes, you are right, that might not increase the line coverage as such.

I think the new added tests should also give good coverage.

nit0906 avatar Aug 10 '22 16:08 nit0906