incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

Supporting website features

Open Run-Lin opened this issue 3 years ago • 7 comments

What changes were proposed in this pull request?

Supporting website features Using https://docusaurus.io/docs/installation Preview the website: https://run-lin.github.io

Why are the changes needed?

At present there is no website, now need a website to do better publicity, let more people know it

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

Run-Lin avatar Jul 26 '22 16:07 Run-Lin

@Run-Lin Thanks for the contribute, and we can add more docs later.

colinmjj avatar Jul 27 '22 01:07 colinmjj

Codecov Report

Merging #87 (c581d36) into master (6cbd9b7) will increase coverage by 0.02%. The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     58.38%   58.40%   +0.02%     
- Complexity     1266     1269       +3     
============================================
  Files           158      158              
  Lines          8417     8426       +9     
  Branches        780      782       +2     
============================================
+ Hits           4914     4921       +7     
- Misses         3251     3253       +2     
  Partials        252      252              
Impacted Files Coverage Δ
...che/uniffle/server/storage/HdfsStorageManager.java 90.00% <83.33%> (-2.69%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 27 '22 02:07 codecov-commenter

I would suggest borrowing the footer from Apache Kvrocks.

kaijchen avatar Jul 27 '22 03:07 kaijchen

Should we add apache license header to every file?

jerqi avatar Jul 27 '22 03:07 jerqi

And it's generally better to put website in a separate repo, such as spark-website.

kaijchen avatar Jul 27 '22 03:07 kaijchen

IIRC, ASF has a boilerplate for project's website, every project can modify based on that example, maybe we should follow that.

jerryshao avatar Jul 27 '22 03:07 jerryshao

I would suggest borrowing the footer from Apache Kvrocks.

It is a good suggestion borrowing the footer from Apache Kvrocks. I took a look at Kvrocks, the website is also built based on docusaurus

Run-Lin avatar Jul 27 '22 10:07 Run-Lin

We have merged https://github.com/apache/incubator-uniffle-website/pull/1 . This pr is duplicated. I'll close this pr.

jerqi avatar Aug 30 '22 03:08 jerqi