incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[Umbrella] Introducing `Cli` to update the configuration file

Open smallzhongfeng opened this issue 2 years ago • 10 comments

Code of Conduct

Search before asking

  • [x] I have searched in the issues and found no similar issues.

Describe the proposal

Currently, our configurations are implemented using the method of scheduling threads, which has some latency. We can add cli methods, which have the following advantages:

  1. Ability to refresh configuration files to memory faster
  2. More secure update configuration

Task list

  • [x] #770
  • [ ] #769
  • [x] #768
  • [ ] #836
  • [x] #837
  • [ ] #846

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

smallzhongfeng avatar Mar 24 '23 11:03 smallzhongfeng

@jerqi @leixm @zuston @advancedxy If you have time, PTAL.

smallzhongfeng avatar Mar 24 '23 11:03 smallzhongfeng

If it's ok, I will go ahead. Gently ping. @jerqi @zuston @kaijchen @advancedxy

smallzhongfeng avatar Mar 27 '23 09:03 smallzhongfeng

Great work. I think cli is a good way for admin to manage cluster. But do we need to trigger updating conf by CLI, the update latency is acceptable for me. Do you meet some problems on this?

zuston avatar Mar 27 '23 13:03 zuston

+1

jerqi avatar Mar 27 '23 16:03 jerqi

As we discussed in #80, should we update conf by REST api?

xianjingfeng avatar Mar 28 '23 02:03 xianjingfeng

If it's ok, I will go ahead. Gently ping. @jerqi @zuston @kaijchen @advancedxy

I think cli is a good way to manage shuffle clusters. I create a cli support ticket for operator to manage cluster: #569.

However your current proposal is more about to update configurations timely and securely. I'm +1 with intention. But as @xianjingfeng point out, do you think it's better to update configurations via REST api?

advancedxy avatar Mar 28 '23 02:03 advancedxy

Great work. I think cli is a good way for admin to manage cluster. But do we need to trigger updating conf by CLI, the update latency is acceptable for me. Do you meet some problems on this?

Not yet, but as I said, when updating, we need to wait with a one minute interval. However, if we use the cli method, we can take effect immediately. And in line with top-level projects, services such as Yarn and Hadoop all provide Cli for configuration updates.

smallzhongfeng avatar Mar 28 '23 02:03 smallzhongfeng

If it's ok, I will go ahead. Gently ping. @jerqi @zuston @kaijchen @advancedxy

I think cli is a good way to manage shuffle clusters. I create a cli support ticket for operator to manage cluster: #569.

However your current proposal is more about to update configurations timely and securely. I'm +1 with intention. But as @xianjingfeng point out, do you think it's better to update configurations via REST api?

Like Yarn, in fact, cli and REST api coexist, and I think we can follow suit.

smallzhongfeng avatar Mar 28 '23 02:03 smallzhongfeng

If it's ok, I will go ahead. Gently ping. @jerqi @zuston @kaijchen @advancedxy

I think cli is a good way to manage shuffle clusters. I create a cli support ticket for operator to manage cluster: #569. However your current proposal is more about to update configurations timely and securely. I'm +1 with intention. But as @xianjingfeng point out, do you think it's better to update configurations via REST api?

Like Yarn, in fact, cli and REST api coexist, and I think we can follow suit.

co-exist works for me.

advancedxy avatar Mar 29 '23 08:03 advancedxy

If it's ok, I will go ahead. Gently ping. @jerqi @zuston @kaijchen @advancedxy

I think cli is a good way to manage shuffle clusters. I create a cli support ticket for operator to manage cluster: #569. However your current proposal is more about to update configurations timely and securely. I'm +1 with intention. But as @xianjingfeng point out, do you think it's better to update configurations via REST api?

Like Yarn, in fact, cli and REST api coexist, and I think we can follow suit.

co-exist works for me.

+1

jerqi avatar Mar 30 '23 03:03 jerqi