incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

Published 20 hours ago • verified publisher icon apache

[#2282][FOLLOWUP] test: Add UT for DelegationRssShuffleManager#getReader

Open maobaolong opened this issue 11 months ago • 4 comments

What changes were proposed in this pull request?

Add UT for DelegationRssShuffleManager#getReader

Why are the changes needed?

Fix: #2282

Does this PR introduce any user-facing change?

No.

How was this patch tested?

New UT

maobaolong avatar Dec 11 '24 01:12 maobaolong

Test Results

 2 927 files   2 927 suites   6h 12m 45s ⏱️  1 097 tests  1 095 ✅  2 💤 0 ❌ 13 655 runs  13 625 ✅ 30 💤 0 ❌

Results for commit 4c395341.

github-actions[bot] avatar Dec 11 '24 02:12 github-actions[bot]

The failed test caused by there is no specific getReader method, in spark 3.0, but it exists in other minor version of spark 3.x

maobaolong avatar Dec 20 '24 23:12 maobaolong

The failed test caused by there is no specific getReader method, in spark 3.0, but it exists in other minor version of spark 3.x

You should use reflection to solve the similar issue.

jerqi avatar Dec 24 '24 03:12 jerqi

@jerqi Sorry I have no idea to solve this mock api through reflection.

maobaolong avatar Jan 06 '25 11:01 maobaolong