incubator-uniffle
incubator-uniffle copied to clipboard
[MINOR] feat(server): Introduce metrics related bitmaps(committedBlockIds/cachedBlockIds/partitionToBlockIds)
What changes were proposed in this pull request?
Introduce metrics related bitmaps.
Why are the changes needed?
Insight the block bitmap related count.
Fix: # (issue)
Does this PR introduce any user-facing change?
- committed_block_count
- reported_block_count
- cached_block_count
How was this patch tested?
Locally.
Test Results
2 926 files +21 2 926 suites +21 5h 56m 58s :stopwatch: + 9m 5s 1 041 tests ± 0 1 039 :white_check_mark: + 1 2 :zzz: ±0 0 :x: - 1 13 003 runs +50 12 973 :white_check_mark: +51 30 :zzz: ±0 0 :x: - 1
Results for commit df4bbd01. ± Comparison against base commit a08c2272.
@zuston Would you like to take a look at this PR? Thank you!
@xianjingfeng @jerqi Look forward to your review, thanks!
Will this pull request be affected by https://github.com/apache/incubator-uniffle/pull/2196?
@jerqi yes, this will conflict if merge #2196, but doesn't matter, I will resolve it
@jerqi Sorry for the mistake reply, these metrics can show the effect of #2196.
For our scenario, we use LOCAL_MEMORY storage type, so the committed_block_count and cached_block_count is 0 after combine these two PRs. I tested on our internal cluster.
@jerqi Sorry for the mistake reply, these metrics can show the effect of #2196.
For our scenario, we use
LOCAL_MEMORYstorage type, so thecommitted_block_countandcached_block_countis0after combine these two PRs. I tested on our internal cluster.
LGTM if it won't throw an error.
@jerqi yeah, it do not throw exception