incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#2015] improvement(netty): Support Netty for MR integration test.

Open qijiale76 opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Support Netty for MR integration test.

Why are the changes needed?

Fix: #2015

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Integration tests themselves.

qijiale76 avatar Aug 06 '24 06:08 qijiale76

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.87%. Comparing base (9f8951f) to head (1a64acf). Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2016      +/-   ##
============================================
+ Coverage     52.35%   52.87%   +0.52%     
- Complexity     2815     3424     +609     
============================================
  Files           452      518      +66     
  Lines         21217    28352    +7135     
  Branches       1950     2650     +700     
============================================
+ Hits          11108    14992    +3884     
- Misses         9401    12394    +2993     
- Partials        708      966     +258     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 06 '24 06:08 codecov-commenter

Test Results

 2 926 files  +31   2 926 suites  +31   6h 15m 20s :stopwatch: + 28m 15s  1 049 tests + 6   1 047 :white_check_mark: + 7   2 :zzz: ±0  0 :x:  - 1  13 045 runs  +72  13 015 :white_check_mark: +73  30 :zzz: ±0  0 :x:  - 1 

Results for commit 1a64acfe. ± Comparison against base commit f9b4c0e0.

This pull request removes 6 and adds 12 tests. Note that renamed tests count towards both.
org.apache.uniffle.test.DynamicConfTest ‑ dynamicConfTest
org.apache.uniffle.test.HadoopConfTest ‑ hadoopConfTest
org.apache.uniffle.test.LargeSorterTest ‑ largeSorterTest
org.apache.uniffle.test.RMWordCountTest ‑ wordCountTest
org.apache.uniffle.test.SecondarySortTest ‑ secondarySortTest
org.apache.uniffle.test.WordCountTest ‑ wordCountTest
org.apache.uniffle.test.DynamicConfTest ‑ dynamicConfTest{ClientType}[1]
org.apache.uniffle.test.DynamicConfTest ‑ dynamicConfTest{ClientType}[2]
org.apache.uniffle.test.HadoopConfTest ‑ hadoopConfTest{ClientType}[1]
org.apache.uniffle.test.HadoopConfTest ‑ hadoopConfTest{ClientType}[2]
org.apache.uniffle.test.LargeSorterTest ‑ largeSorterTest{ClientType}[1]
org.apache.uniffle.test.LargeSorterTest ‑ largeSorterTest{ClientType}[2]
org.apache.uniffle.test.RMWordCountTest ‑ wordCountTest{ClientType}[1]
org.apache.uniffle.test.RMWordCountTest ‑ wordCountTest{ClientType}[2]
org.apache.uniffle.test.SecondarySortTest ‑ secondarySortTest{ClientType}[1]
org.apache.uniffle.test.SecondarySortTest ‑ secondarySortTest{ClientType}[2]
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 06 '24 06:08 github-actions[bot]

LGTM! wait for ci!

zhengchenyu avatar Oct 21 '24 03:10 zhengchenyu