incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#1644] feat(common/coordinator): Add TotalRpcsProcessingTimeUs, TotalRpcsOps with an example

Open maobaolong opened this issue 1 year ago • 5 comments

What changes were proposed in this pull request?

  • Introduce a util class RpcUtils to handle metrics and logs for each rpc call
  • Modified the Metrics Counter to support getOrAdd and counter for inc a value.
  • Setup this for two methods of Coordinator rpc handler.

Why are the changes needed?

Fix: #1644.

Does this PR introduce any user-facing change?

Add two metrics.

How was this patch tested?

image

maobaolong avatar Jul 05 '24 01:07 maobaolong

Test Results

 2 657 files  +1   2 657 suites  +1   5h 30m 37s :stopwatch: -6s    946 tests ±0     945 :white_check_mark: +1   1 :zzz: ±0  0 :x:  - 1  11 789 runs  +1  11 774 :white_check_mark: +2  15 :zzz: ±0  0 :x:  - 1 

Results for commit d71c1c98. ± Comparison against base commit 7f74dafc.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 05 '24 01:07 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 53.10%. Comparing base (dddcced) to head (1795277). Report is 35 commits behind head on master.

Files Patch % Lines
...n/java/org/apache/uniffle/common/rpc/RpcUtils.java 0.00% 30 Missing :warning:
...he/uniffle/coordinator/CoordinatorGrpcService.java 0.00% 19 Missing :warning:
.../org/apache/uniffle/common/metrics/RPCMetrics.java 0.00% 7 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1864      +/-   ##
============================================
- Coverage     53.53%   53.10%   -0.44%     
- Complexity     2356     2995     +639     
============================================
  Files           368      448      +80     
  Lines         16852    24437    +7585     
  Branches       1540     2278     +738     
============================================
+ Hits           9022    12977    +3955     
- Misses         7303    10655    +3352     
- Partials        527      805     +278     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 05 '24 02:07 codecov-commenter

cc @zhengchenyu @qijiale76

rickyma avatar Jul 05 '24 03:07 rickyma

Do we still need this?

rickyma avatar Jul 17 '24 18:07 rickyma

@rickyma I mark this PR as draft, thanks for your review before!

maobaolong avatar Aug 03 '24 01:08 maobaolong