incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[FEATURE] support use skip list to store shuffleBuffer in memory

Open xianjingfeng opened this issue 1 year ago • 2 comments

Code of Conduct

Search before asking

  • [X] I have searched in the issues and found no similar issues.

Describe the feature

Currently, we use linkedList to store shuffleBuffer in memory. If we assign a lot of memory(1TB) to the shuffle server, the performance will not be good while getting data from memory. Because every request needs to look for lastBlockId from the head position.

Other benefits of using skip list:

  1. Fix #926
  2. We don't need to sort data while flushing data to disk. #137

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

xianjingfeng avatar May 13 '24 03:05 xianjingfeng

We need to guarantee the order of data, otherwise we will lose the data.

jerqi avatar May 17 '24 09:05 jerqi

We need to guarantee the order of data, otherwise we will lose the data.

Get it. This feature will not support slow start. I'm going to make it an optional feature.

xianjingfeng avatar May 17 '24 10:05 xianjingfeng