[#1304] Improvement(rss-client-mr): Using configOption in RssMRConfig
What changes were proposed in this pull request?
as title, Using configOption in RssMRConfig
Why are the changes needed?
Fix: #1304
Does this PR introduce any user-facing change?
No.
How was this patch tested?
existing unit tests
Codecov Report
Attention: 125 lines in your changes are missing coverage. Please review.
Comparison is base (
5d027c0) 53.38% compared to head (1eddea0) 54.68%.
Additional details and impacted files
@@ Coverage Diff @@
## master #1427 +/- ##
============================================
+ Coverage 53.38% 54.68% +1.30%
- Complexity 2729 2730 +1
============================================
Files 422 402 -20
Lines 24046 21935 -2111
Branches 2051 2058 +7
============================================
- Hits 12836 11995 -841
+ Misses 10412 9213 -1199
+ Partials 798 727 -71
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @zuston , would you help review this PR when you hava time?
Hi @jerqi @zuston , PTAL
Could you help review this? @zhengchenyu
I still have my doubts about MRClientConf, same with #1303. I think MRClientConf should not be extended from RssBaseConf, but RssClientConf.
I still have my doubts about MRClientConf, same with #1303. I think MRClientConf should not be extended from RssBaseConf, but RssClientConf.
RssBaseConf may contain some config options which are dedicated to the server.