incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[Improvement] Avoid starting unused threads in spark driver

Open zuston opened this issue 3 years ago • 2 comments

What changes were proposed in this pull request?

Avoid starting unused threads in spark driver

Why are the changes needed?

In Spark RssShuffleManager, for the role of driver, there is no need to start send blocks threads.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

zuston avatar Aug 05 '22 06:08 zuston

Actually I think it brings extra complexity in order to avoid initializing a thread, it's a little worthless.

jerqi avatar Aug 05 '22 11:08 jerqi

Actually I think it brings extra complexity in order to avoid initializing a thread, it's a little worthless.

OK.

zuston avatar Aug 05 '22 13:08 zuston

I'll close it, if you have another better solution, you can raise another pr.

jerqi avatar Aug 22 '22 02:08 jerqi