incubator-seata-go icon indicating copy to clipboard operation
incubator-seata-go copied to clipboard

Split client.Init into rm.Init and tm.Init methods

Open jasondeng1997 opened this issue 3 years ago • 3 comments
trafficstars

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


jasondeng1997 avatar Sep 21 '22 02:09 jasondeng1997

Codecov Report

Merging #286 (42e23a5) into master (cffa619) will decrease coverage by 0.16%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   50.28%   50.11%   -0.17%     
==========================================
  Files          63       66       +3     
  Lines        3305     3376      +71     
==========================================
+ Hits         1662     1692      +30     
- Misses       1553     1594      +41     
  Partials       90       90              
Impacted Files Coverage Δ
pkg/rm/init.go 0.00% <0.00%> (ø)
pkg/tm/init.go 0.00% <0.00%> (ø)
pkg/tm/global_transaction.go 94.49% <0.00%> (-0.06%) :arrow_down:
pkg/util/backoff/backoff.go 51.66% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 21 '22 05:09 codecov-commenter

这个pr的意义我说一下,之前的tm和rm在一个包下面,逻辑混乱,但是之前的引用还没有改,所以后续还要修改引用,防止有错误。

jasondeng1997 avatar Sep 24 '22 13:09 jasondeng1997

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Let me tell you the meaning of this pr. The previous tm and rm are under the same package, and the logic is confusing, but the previous reference has not been changed, so the reference must be modified in the future to prevent errors.

Issues-translate-bot avatar Sep 24 '22 13:09 Issues-translate-bot