incubator-pagespeed-ngx icon indicating copy to clipboard operation
incubator-pagespeed-ngx copied to clipboard

Update Nginx in Docker

Open vitaliytv opened this issue 6 years ago • 6 comments
trafficstars

Stable from 1.14.1 to 1.14.2 Mainline from 1.15.6 to 1.15.8

vitaliytv avatar Jan 13 '19 11:01 vitaliytv

lgtm, but let's see if @nberlee has any remarks

oschaaf avatar Jan 14 '19 15:01 oschaaf

Have you tested this? Everything broke in Alpine Edge because of the LibreSSL to OpenSSL 1.1 switch. These are basically the same changes I did in https://github.com/nberlee/incubator-pagespeed-ngx but as the build failed I wanted to repair it first before upping the version number.

Also in the 1.14.2 releasenote it says that its now compiling with GCC 8.1 and there the patch of nginx is not needed anymore.

nberlee avatar Jan 14 '19 17:01 nberlee

Sorry, my fault with alpine edge, can I exclude edge?

vitaliytv avatar Jan 14 '19 17:01 vitaliytv

Shouldn't we get ngx_pagspeed working on OpenSSL 1.1 instead of just installing LibreSSL? OpenSSL seems to be much more popular, it's the default on alpine now and it supports TLS 1.3 unlike LibreSSL.

sachk avatar Feb 13 '19 22:02 sachk

I have a docker image working and always updated with the latest nginx mainline (1.7.3), openssl 1.1.1x and the latest pagespeed.

https://cloud.docker.com/repository/docker/extremeshok/nginx-pagespeed

extremeshok avatar Aug 16 '19 16:08 extremeshok

I have a docker image working and always updated with the latest nginx mainline (1.7.3), openssl 1.1.1x and the latest pagespeed.

https://cloud.docker.com/repository/docker/extremeshok/nginx-pagespeed

Hello, backward compatibility?

If I just change pagespeed/nginx-pagespeed to extremeshok/nginx-pagespeed should everything work right away?

zamanuhina avatar Jan 14 '21 22:01 zamanuhina

Closing this in an effort to clean up stale pull requests (but feel free to re-open if you want to pick this up again).

oschaaf avatar Aug 30 '22 21:08 oschaaf