incubator-pagespeed-ngx icon indicating copy to clipboard operation
incubator-pagespeed-ngx copied to clipboard

Add AUTH support for redis backend

Open onnimonni opened this issue 8 years ago • 5 comments

I'm opening a new issue for this like @jmarantz suggested in https://github.com/pagespeed/ngx_pagespeed/issues/777#issuecomment-273570987.

ngx_pagespeed has been supporting redis as a cache backend from version 1.12.34.1.

Redis instances can be started with requirepass password directive. After this client applications must provide AUTH password command to authenticate into redis.

It would be nice if ngx_pagespeed could support this functionality too.

onnimonni avatar Jun 15 '17 16:06 onnimonni

was this ever implemented ?

centminmod avatar Sep 11 '17 12:09 centminmod

@centminmod AFAIK no it wasn't

onnimonni avatar Sep 11 '17 12:09 onnimonni

thanks for info @onnimonni

centminmod avatar Sep 11 '17 23:09 centminmod

This is a blocker for my ability to connect pagespeed to our redis backend. Hopefully this will get some traction soon-ish.

maxolasersquad avatar Dec 10 '19 19:12 maxolasersquad

For anyone willing to help out with this, this might not be super hard. See https://github.com/apache/incubator-pagespeed-mod/pull/1854/files for an example of how to wire up a redis-based option. I assume a modification to RedisCache::StartUp() is required to authenticate after opening a connection to redis.

oschaaf avatar Dec 11 '19 11:12 oschaaf