incubator-pagespeed-ngx icon indicating copy to clipboard operation
incubator-pagespeed-ngx copied to clipboard

Error: Pagespeed broken header with HTTP2

Open erickponce opened this issue 8 years ago • 5 comments

Hello everyone,

Nginx pagespeed is reporting this error: broken header: "��/���@��kj98���=5���g@D�</A " while reading PROXY protocol, client: xxxxxxx, server: 0.0.0.0:443

only when using HTTP2, is there a pagespeed config im missing?

erickponce avatar Mar 06 '17 13:03 erickponce

We don't have any tests with proxy_protocol turned on in the configuration, but I would expect the feature to be transparent to our module.

So before diving in deeper, it would be helpful to know if the error still gets logged when ngx_pagespeed is not involved. You can take it out of the equation by configuring:

pagespeed off;
pagespeed InPlaceResourceOptimization off;

Can you try that and post back whether that stopped further logging of that error message?

oschaaf avatar Mar 06 '17 13:03 oschaaf

Hi oschaaf thanks for your reply,

Yes, I can confirm that this error log stops when I turn pagespeed off, In fact the prefix for the log entry is "pagespeed" so I think he is the module generating the error.

erickponce avatar Mar 06 '17 14:03 erickponce

Thanks. These lines look relevant: https://github.com/nginx/nginx/blob/master/src/http/v2/ngx_http_v2.c#L686 https://github.com/nginx/nginx/blob/master/src/core/ngx_proxy_protocol.c#L120

Could you try if configuring the module to load files directly from disk avoids these log lines?: https://modpagespeed.com/doc/domains#ModPagespeedLoadFromFile

Alternatively, I think that pointing mod_pagespeed to fetch via the proxy may also help: https://modpagespeed.com/doc/domains#mapping_origin

(either one of those would be good to try)

oschaaf avatar Mar 06 '17 15:03 oschaaf

I can confirm that I am seeing the same issue here

gnif avatar Apr 18 '19 08:04 gnif

I had the same issue, but it somehow disappeared when I switched from TCP to unix socket...

ghost avatar Jun 11 '19 10:06 ghost