incubator-pagespeed-mod icon indicating copy to clipboard operation
incubator-pagespeed-mod copied to clipboard

Published 20 hours ago • verified publisher icon apache

PR 2017 -- non-trivial changes follow up reminder

Open oschaaf opened this issue 5 years ago • 0 comments
trafficstars

PR #2017 is mostly mechanical stuff to fix build warnings and generally clean up, but in there are two changes that should have gone elsewhere. I'm going to merge that PR as is, but leave a note here to make sure we go over these separately

  • RedisCache updated lock annotation + cleanup https://github.com/apache/incubator-pagespeed-mod/pull/2017/files#diff-f227b6faa8dc001f2312dadc7d72e53cL179
  • RewriteDriver::IsEqual appears to need an extra lock, which I added: https://github.com/apache/incubator-pagespeed-mod/pull/2017/files#diff-2dfa84a0e17c82eca00eda480a713f5fR3869

Especially the RewriteDriver change seems tricky, as there are now two locks involved, risking deadlock if the change was bad.

oschaaf avatar Aug 04 '20 12:08 oschaaf