incubator-devlake icon indicating copy to clipboard operation
incubator-devlake copied to clipboard

feat(docker-compose): add a way to change default datasource

Open riipeckx opened this issue 1 year ago • 7 comments

Summary

As I'd like to use PostgreSQL, I added a way to set the default datasource via environment variables.

riipeckx avatar Oct 02 '24 17:10 riipeckx

LGTM, did you test it? did it work?

klesh avatar Oct 08 '24 04:10 klesh

LGTM, did you test it? did it work?

I tested it locally, and it worked well :)

riipeckx avatar Oct 08 '24 05:10 riipeckx

I am afraid this would affect helm chart and release procedure as well. We need more input about this @matrixji @JorgeGar @d4x1 What do you guys think?

klesh avatar Nov 01 '24 06:11 klesh

@klesh Yes hel charts should be updated too @riipeckx https://github.com/apache/incubator-devlake-helm-chart/blob/main/charts/devlake/values.yaml

d4x1 avatar Nov 01 '24 08:11 d4x1

I'll check this out asap :)

victormrc-betclic avatar Nov 12 '24 08:11 victormrc-betclic

I'm working on helm charts updates in the given repo.

riipeckx avatar Nov 15 '24 09:11 riipeckx

LGTM. Please consider @klesh 's comments.

d4x1 avatar Nov 19 '24 03:11 d4x1

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Jul 05 '25 00:07 github-actions[bot]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

github-actions[bot] avatar Jul 12 '25 00:07 github-actions[bot]