incubator-devlake icon indicating copy to clipboard operation
incubator-devlake copied to clipboard

[Bug][GitHub] Missing Pull Request data when changing the Time Range in Sync Policy

Open d4x1 opened this issue 1 year ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

What happened

Some users set up a new project whose connection is GitHub with onboarding guide, because https://github.com/apache/incubator-devlake/issues/7703, graphql API is not enabled.This produces two records in pull_requests table. When users update the time range in project's sync policy config, and click COLLECT DATA. The new pipeline is triggered and finished successfully. But the data in pull_requests table is incorrected: it still has only two records, but the new time range has more pull requests definitely.

What do you expect to happen

When Time Range option in Sync Policy Config changes, all pull requests should be fetched according to the new time range.

How to reproduce

Ses "what happened"

Anything else

No response

Version

2e56bdd

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

d4x1 avatar Jul 08 '24 08:07 d4x1

I think it's related to GitHub's PR collector, but due to the small rate limit in GitHub restful API. We should use graphql as much as possible.

d4x1 avatar Jul 08 '24 09:07 d4x1

This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Sep 07 '24 00:09 github-actions[bot]