fix(metadata): remove redundant last-column-id parameter
attempt to fix https://github.com/apache/iceberg/issues/13850
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
Met the same problem, is this PR still in progress?
@mxdzs0612 waiting on review
We ran into the same issue, but I believe it should already be fixed in the new Iceberg 1.10 release. This commit removed the logic of reading the last-column-id, since it was indeed unnecessary. So even if the client sends an incorrect last-column-id, the new server will no longer use it.
I think upgrading the IRC server to the new 1.10 version should resolve the problem. Have you tried the new version? @twuebi
@zhongyujiang I don't think it fixes the issue, the current PR is from September, the commit you are referring to is from February.
@twuebi The fix PR is only included in version 1.10, which was released in Sep. And I’ve verified it. I backported it to a lower version in our internal setup(we haven't upgraded to 1.10 yet), and it indeed resolves the issue.
@zhongyujiang the issue's scope is larger than the IRC server fixture. SetCurrentSchema on current main still exposes the parameter instead of computing this internally. Please take a look at https://github.com/apache/iceberg/issues/13850 for more context.
SetCurrentSchema on current main still exposes the parameter instead of computing this internally.
Oh, got it.