iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard
verified publisher icon apache

[feature request] Improve integration test reliance on docker

Open kevinjqliu opened this issue 1 year ago • 6 comments

Feature Request / Improvement

It would be nice to eliminate the sleep 10 and instead use health checks for the underlying containers. https://github.com/apache/iceberg-python/blob/188e2c4d63f294fc55351916fb8d62a5a4401d3d/Makefile#L43

The sleep here is a proxy for waiting for REST/HMS services to be available.

kevinjqliu avatar Apr 19 '24 20:04 kevinjqliu

@kevinjqliu Did you guys consider using testcontainers?

AronsonDan avatar May 02 '24 08:05 AronsonDan

@AronsonDan I have not heard of this before. I'll take a look, thank you!

kevinjqliu avatar May 03 '24 19:05 kevinjqliu

Would love to give a hand setting up testconteiners using pytest

AronsonDan avatar May 03 '24 20:05 AronsonDan

@AronsonDan please do! Feel free to tag me or reach out with any questions

kevinjqliu avatar May 03 '24 20:05 kevinjqliu

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

github-actions[bot] avatar Oct 31 '24 00:10 github-actions[bot]