hudi
hudi copied to clipboard
[HUDI-7704] Unify test client storage classes with duplicate code
Change Logs
TestHoodieClientOnCopyOnWriteStorage and TestHoodieJavaClientOnCopyOnWriteStorage have a bunch of duplicate code, so i:
- extracted common code (with some parameterizations) to HoodieWriterClientTestHarness class;
- removed unused code;
- moved static assertions-methods to existing separate class Assertions.
I did not add, remove or change subject of any test, I've just refactored these classes to avoid code duplications.
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
none
- The config description must be updated if new configs are added or the default value of the configs are changed
- Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.
Contributor's checklist
- [ ] Read through contributor's guide
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
cc @the-other-tim-brown for the code reviewing.
I'm tired of resolving conflicts for this PR again and again. Somebody review it and merge, please!
Just a couple minor nitpicks but the refactor looks good to me
CI report:
- dd052193e61243e0f2228fe8993851ac066dbdda Azure: SUCCESS
Bot commands
@hudi-bot supports the following commands:@hudi-bot run azurere-run the last Azure build