hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

YARN-11262: [hadoop-yarn-server-resourcemanager] Upgrade to Junit 5

Open andreoss opened this issue 3 years ago • 4 comments

Description of PR

Upgrade to Junit 5

How was this patch tested?

mvn test

For code changes:

  • [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

andreoss avatar Sep 19 '22 17:09 andreoss

Hi @andreoss, Thanks for you PR. I have already been working on it in my local and make some good progress as well. It would be great if you can ask on JIRA before starting the work if assigned JIRA person is working on it or not. Thanks.

hotcodemacha avatar Sep 19 '22 17:09 hotcodemacha

@ashutoshcipher Understood. Any chance this can be merged? In this PR, only Parameterized tests are left intact, the rest are converted to Junit 5. The Parameterized tests require some refactoring which I would like to be in a separate PR to ease review

andreoss avatar Sep 19 '22 18:09 andreoss

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 5s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 300 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 42m 11s trunk passed
+1 :green_heart: compile 1m 14s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 1m 4s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 15s trunk passed
+1 :green_heart: mvnsite 1m 9s trunk passed
+1 :green_heart: javadoc 1m 3s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 0m 50s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 2m 21s trunk passed
+1 :green_heart: shadedclient 25m 7s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 1m 1s the patch passed
+1 :green_heart: compile 1m 9s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
-1 :x: javac 1m 9s /results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 9 new + 208 unchanged - 19 fixed = 217 total (was 227)
+1 :green_heart: compile 0m 59s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
-1 :x: javac 0m 59s /results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 9 new + 165 unchanged - 19 fixed = 174 total (was 184)
-1 :x: blanks 0m 0s /blanks-eol.txt The patch has 53 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 :x: blanks 0m 0s /blanks-tabs.txt The patch 1 line(s) with tabs.
-0 :warning: checkstyle 1m 5s /results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 585 new + 2570 unchanged - 71 fixed = 3155 total (was 2641)
+1 :green_heart: mvnsite 1m 1s the patch passed
+1 :green_heart: javadoc 0m 43s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 0m 40s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 2m 7s the patch passed
+1 :green_heart: shadedclient 24m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 :x: unit 180m 14s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager in the patch passed.
+1 :green_heart: asflicense 0m 40s The patch does not generate ASF License warnings.
294m 10s
Reason Tests
Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue
hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions
hadoop.yarn.server.resourcemanager.rmapp.attempt.TestRMAppAttemptTransitions
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestResourceVector
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
hadoop.yarn.server.resourcemanager.scheduler.fair.converter.TestFSQueueConverter
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerFairShare
hadoop.yarn.server.resourcemanager.reservation.TestCapacitySchedulerPlanFollower
hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestAbsoluteResourceWithAutoQueue
hadoop.yarn.server.resourcemanager.scheduler.capacity.conf.TestQueueCapacityConfigParser
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestUsersManager
hadoop.yarn.server.resourcemanager.reservation.TestNoOverCommitPolicy
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueManagementDynamicEditPolicy
hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicyMockFramework
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueParsing
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate
hadoop.yarn.server.resourcemanager.TestRMAdminService
hadoop.yarn.server.resourcemanager.TestRMEmbeddedElector
hadoop.yarn.server.resourcemanager.TestAppManager
hadoop.yarn.server.resourcemanager.reservation.TestFairSchedulerPlanFollower
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerQueueACLs
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerAutoQueueCreation
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs
hadoop.yarn.server.resourcemanager.TestReservationSystemWithRMHA
hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy
hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicyPreemptToBalance
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4910/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4910
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 3a6622b9d451 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 38b9d14b9219f0649a374403cfc2c2e06b29af6e
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4910/1/testReport/
Max. process+thread count 2170 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4910/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 19 '22 22:09 hadoop-yetus

@ashutoshcipher can i continue to work on that or should i take something else?

andreoss avatar Oct 03 '22 01:10 andreoss