hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

YARN-11264. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests

Open hotcodemacha opened this issue 3 years ago • 7 comments
trafficstars

Description of PR

Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests

JIRA - YARN-11264

For code changes:

  • [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hotcodemacha avatar Aug 20 '22 22:08 hotcodemacha

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 56s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 9 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 39m 14s trunk passed
+1 :green_heart: compile 0m 46s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 0m 44s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 0m 48s trunk passed
+1 :green_heart: mvnsite 0m 48s trunk passed
+1 :green_heart: javadoc 0m 51s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 0m 41s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 59s branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no spotbugs output file (spotbugsXml.xml)
+1 :green_heart: shadedclient 20m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 45s the patch passed
+1 :green_heart: compile 0m 28s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javac 0m 28s the patch passed
+1 :green_heart: compile 0m 26s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 0m 26s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 26s /results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: The patch generated 12 new + 19 unchanged - 20 fixed = 31 total (was 39)
+1 :green_heart: mvnsite 0m 29s the patch passed
+1 :green_heart: javadoc 0m 23s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 0m 23s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests has no data from spotbugs
+1 :green_heart: shadedclient 23m 55s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 3m 29s hadoop-yarn-server-tests in the patch passed.
+1 :green_heart: asflicense 0m 47s The patch does not generate ASF License warnings.
100m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4776
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 9a6ff63dc9fa 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1e3ddb779f4d080242c4362da9f55d541a26003d
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/1/testReport/
Max. process+thread count 653 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 21 '22 00:08 hadoop-yetus

@aajisaka - Please help in reviewing the PR. Thanks.

hotcodemacha avatar Aug 30 '22 08:08 hotcodemacha

@aajisaka - As discussed, added junit-platform-launcher dependency

hotcodemacha avatar Aug 30 '22 12:08 hotcodemacha

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 1m 1s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 9 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 38m 33s trunk passed
+1 :green_heart: compile 0m 45s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 0m 36s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 0m 43s trunk passed
+1 :green_heart: mvnsite 0m 39s trunk passed
+1 :green_heart: javadoc 0m 50s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 0m 33s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 53s branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no spotbugs output file (spotbugsXml.xml)
+1 :green_heart: shadedclient 20m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 25s the patch passed
+1 :green_heart: compile 0m 25s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javac 0m 25s the patch passed
+1 :green_heart: compile 0m 23s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 0m 23s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 22s /results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: The patch generated 12 new + 19 unchanged - 20 fixed = 31 total (was 39)
+1 :green_heart: mvnsite 0m 26s the patch passed
+1 :green_heart: javadoc 0m 19s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 0m 19s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests has no data from spotbugs
+1 :green_heart: shadedclient 19m 40s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 3m 33s hadoop-yarn-server-tests in the patch passed.
+1 :green_heart: asflicense 0m 49s The patch does not generate ASF License warnings.
94m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4776
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 1aef96862822 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b579b2f2fda4d8c3198197e7791367e2c9198be8
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/2/testReport/
Max. process+thread count 722 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 30 '22 13:08 hadoop-yetus

@aajisaka - Please help in reviewing the PR. Thanks.

hotcodemacha avatar Sep 07 '22 22:09 hotcodemacha

@aajisaka - Please help in reviewing the PR. Thanks.

hotcodemacha avatar Oct 01 '22 17:10 hotcodemacha

@aajisaka Please help in reviewing the PR. Thank you so much.

hotcodemacha avatar Oct 09 '22 15:10 hotcodemacha

BTW, I noticed TimelineVersionWatcher and TimelineVersion are unused. I think they can be removed by a separate jira.

aajisaka avatar Oct 29 '22 19:10 aajisaka

BTW, I noticed TimelineVersionWatcher and TimelineVersion are unused. I think they can be removed by a separate jira.

Thanks @aajisaka for reviewing. I will create another JIRA to remove unsed TimelineVersionWatcher and TimelineVersionWatcher

JIRA - YARN-11363

hotcodemacha avatar Oct 29 '22 19:10 hotcodemacha

Merged. Thank you for the contribution and opening an additional JIRA!

aajisaka avatar Oct 29 '22 19:10 aajisaka