hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

Open hotcodemacha opened this issue 3 years ago • 21 comments
trafficstars

Description of PR

Add GETFILEBLOCKLOCATIONS operation to HttpFS.

JIRA - HDFS-6874

How was this patch tested?

UT

For code changes:

  • [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hotcodemacha avatar Aug 16 '22 21:08 hotcodemacha

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 2s codespell was not available.
+0 :ok: detsecrets 0m 2s detect-secrets was not available.
+0 :ok: xmllint 0m 2s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 31s Maven dependency ordering for branch
+1 :green_heart: mvninstall 27m 6s trunk passed
+1 :green_heart: compile 6m 45s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 6m 10s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 37s trunk passed
+1 :green_heart: mvnsite 3m 48s trunk passed
+1 :green_heart: javadoc 2m 53s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 3m 8s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 32s trunk passed
+1 :green_heart: shadedclient 22m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 32s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 49s the patch passed
+1 :green_heart: compile 6m 41s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javac 6m 41s the patch passed
+1 :green_heart: compile 6m 18s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 6m 18s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 1m 23s /results-checkstyle-hadoop-hdfs-project.txt hadoop-hdfs-project: The patch generated 5 new + 419 unchanged - 1 fixed = 424 total (was 420)
+1 :green_heart: mvnsite 3m 13s the patch passed
+1 :green_heart: javadoc 2m 16s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 2m 37s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 26s the patch passed
+1 :green_heart: shadedclient 21m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 39s hadoop-hdfs-client in the patch passed.
+1 :green_heart: unit 242m 20s hadoop-hdfs in the patch passed.
+1 :green_heart: unit 7m 1s hadoop-hdfs-httpfs in the patch passed.
+1 :green_heart: asflicense 1m 11s The patch does not generate ASF License warnings.
408m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4750
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 9222d08d5290 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b78a8732ee678c8af508183bce10d07986d29ece
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/1/testReport/
Max. process+thread count 3263 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 17 '22 13:08 hadoop-yetus

@amahussein @jojochuang - Can you please help in reviewing this PR? Thanks.

hotcodemacha avatar Aug 17 '22 16:08 hotcodemacha

@ferhui - Can you please help in reviewing this. Thanks.

hotcodemacha avatar Sep 13 '22 03:09 hotcodemacha

@ashutoshcipher Thanks for involving me. Will look into it when I am available. One or two days later.

ferhui avatar Sep 13 '22 03:09 ferhui

@ashutoshcipher Thanks for involving me. Will look into it when I am available. One or two days later.

@ferhui Thank you so much. Please take your time.

hotcodemacha avatar Sep 13 '22 03:09 hotcodemacha

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 59s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 52s Maven dependency ordering for branch
+1 :green_heart: mvninstall 28m 57s trunk passed
+1 :green_heart: compile 7m 4s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 6m 22s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 32s trunk passed
+1 :green_heart: mvnsite 3m 32s trunk passed
+1 :green_heart: javadoc 2m 36s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 0s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 18s trunk passed
+1 :green_heart: shadedclient 23m 21s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 24s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 40s the patch passed
+1 :green_heart: compile 6m 49s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 6m 49s the patch passed
+1 :green_heart: compile 6m 16s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 6m 16s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 18s hadoop-hdfs-project: The patch generated 0 new + 417 unchanged - 1 fixed = 417 total (was 418)
+1 :green_heart: mvnsite 2m 55s the patch passed
+1 :green_heart: javadoc 2m 3s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 2m 26s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 17s the patch passed
+1 :green_heart: shadedclient 23m 17s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 29s hadoop-hdfs-client in the patch passed.
-1 :x: unit 333m 39s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
-1 :x: unit 0m 50s /patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt hadoop-hdfs-httpfs in the patch failed.
+1 :green_heart: asflicense 0m 56s The patch does not generate ASF License warnings.
496m 18s
Reason Tests
Failed junit tests hadoop.hdfs.server.mover.TestMover
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4750
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 8305deff00da 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f28c02582752d122892182f0c9621dfc968d638a
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/2/testReport/
Max. process+thread count 2327 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 23 '22 05:09 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 57s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 59s Maven dependency ordering for branch
+1 :green_heart: mvninstall 28m 51s trunk passed
+1 :green_heart: compile 6m 47s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 6m 26s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 33s trunk passed
+1 :green_heart: mvnsite 3m 33s trunk passed
+1 :green_heart: javadoc 2m 39s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 10s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 34s trunk passed
+1 :green_heart: shadedclient 23m 52s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 30s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 52s the patch passed
+1 :green_heart: compile 7m 6s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 7m 6s the patch passed
+1 :green_heart: compile 6m 40s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 6m 40s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 29s hadoop-hdfs-project: The patch generated 0 new + 417 unchanged - 1 fixed = 417 total (was 418)
+1 :green_heart: mvnsite 3m 29s the patch passed
+1 :green_heart: javadoc 2m 10s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 2m 34s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 8m 6s the patch passed
+1 :green_heart: shadedclient 24m 15s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 28s hadoop-hdfs-client in the patch passed.
+1 :green_heart: unit 352m 25s hadoop-hdfs in the patch passed.
+1 :green_heart: unit 9m 2s hadoop-hdfs-httpfs in the patch passed.
+1 :green_heart: asflicense 0m 55s The patch does not generate ASF License warnings.
527m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4750
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 0ed9f32fb78e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b8d0d52f7d578597233500b8a2e57e9be5489162
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/3/testReport/
Max. process+thread count 2313 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 23 '22 20:09 hadoop-yetus

@ferhui - Please help with review. Thanks.

hotcodemacha avatar Sep 23 '22 21:09 hotcodemacha

@ZanderXu @ferhui - Please help in review. Thanks.

hotcodemacha avatar Oct 01 '22 17:10 hotcodemacha

@ZanderXu @ferhui - Please help in review whenever you get chance. Thanks.

hotcodemacha avatar Oct 04 '22 21:10 hotcodemacha

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 49s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 16m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 26m 11s trunk passed
+1 :green_heart: compile 6m 12s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 5m 54s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 34s trunk passed
+1 :green_heart: mvnsite 3m 50s trunk passed
+1 :green_heart: javadoc 2m 43s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 29s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 26s trunk passed
+1 :green_heart: shadedclient 20m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 33s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 43s the patch passed
+1 :green_heart: compile 6m 5s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 6m 5s the patch passed
+1 :green_heart: compile 5m 43s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 5m 43s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 13s hadoop-hdfs-project: The patch generated 0 new + 417 unchanged - 1 fixed = 417 total (was 418)
+1 :green_heart: mvnsite 2m 59s the patch passed
+1 :green_heart: javadoc 2m 8s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 2m 39s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
-1 :x: spotbugs 3m 27s /new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 :green_heart: shadedclient 20m 24s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 36s hadoop-hdfs-client in the patch passed.
-1 :x: unit 249m 24s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
-1 :x: unit 6m 44s /patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt hadoop-hdfs-httpfs in the patch passed.
+1 :green_heart: asflicense 1m 12s The patch does not generate ASF License warnings.
410m 32s
Reason Tests
SpotBugs module:hadoop-hdfs-project/hadoop-hdfs
There is an apparent infinite recursive loop in org.apache.hadoop.hdfs.web.JsonUtil.toJsonString(BlockLocation[]) At JsonUtil.java:recursive loop in org.apache.hadoop.hdfs.web.JsonUtil.toJsonString(BlockLocation[]) At JsonUtil.java:[line 712]
Failed junit tests hadoop.fs.TestSWebHdfsFileContextMainOperations
hadoop.hdfs.web.TestWebHdfsFileSystemContract
hadoop.hdfs.web.TestWebHDFS
hadoop.hdfs.web.TestWebHdfsUrl
hadoop.hdfs.server.namenode.ha.TestObserverNode
hadoop.fs.TestWebHdfsFileContextMainOperations
hadoop.fs.http.client.TestHttpFSWithHttpFSFileSystem
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/4/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4750
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 8d1a6cac5c99 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d19311b9262f65df8e0feef7478ee4551bc05fd3
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/4/testReport/
Max. process+thread count 2869 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Oct 06 '22 21:10 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 16m 31s Maven dependency ordering for branch
+1 :green_heart: mvninstall 28m 45s trunk passed
+1 :green_heart: compile 7m 3s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 6m 26s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 33s trunk passed
+1 :green_heart: mvnsite 3m 33s trunk passed
+1 :green_heart: javadoc 2m 36s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 2m 57s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 23s trunk passed
+1 :green_heart: shadedclient 23m 29s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 26s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 45s the patch passed
+1 :green_heart: compile 6m 39s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 6m 39s the patch passed
+1 :green_heart: compile 6m 12s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 6m 12s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 17s hadoop-hdfs-project: The patch generated 0 new + 417 unchanged - 1 fixed = 417 total (was 418)
+1 :green_heart: mvnsite 2m 56s the patch passed
+1 :green_heart: javadoc 2m 2s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 2m 31s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 18s the patch passed
+1 :green_heart: shadedclient 23m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 26s hadoop-hdfs-client in the patch passed.
+1 :green_heart: unit 356m 40s hadoop-hdfs in the patch passed.
-1 :x: unit 9m 32s /patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt hadoop-hdfs-httpfs in the patch passed.
+1 :green_heart: asflicense 0m 55s The patch does not generate ASF License warnings.
529m 33s
Reason Tests
Failed junit tests hadoop.fs.http.client.TestHttpFSWithHttpFSFileSystem
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/5/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4750
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux b1f609b50d6e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c6761afe614978d0b381ed2a924e9f8abf417a57
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/5/testReport/
Max. process+thread count 2199 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Oct 08 '22 03:10 hadoop-yetus

hadoop.fs.http.client.TestHttpFSWithHttpFSFileSystem

Is passing in local. Will trigger jenkins once again after getting current code being reviewed

hotcodemacha avatar Oct 08 '22 11:10 hotcodemacha

Hi @ZanderXu - Can you please help in reviewing ? Thank you so much.

hotcodemacha avatar Oct 08 '22 11:10 hotcodemacha

Thanks @ZanderXu for review.

I just think that it's an invalidate code line. Because the serialized code didn't serialize it. Not block this PR.

Thanks for mentioning not being a blocker in this PR.

It's ok. But I like to minimize modification.

Reverted the import changes in my latest commit.

hotcodemacha avatar Oct 09 '22 07:10 hotcodemacha

Thanks @ZanderXu for your review and final approval :)

hotcodemacha avatar Oct 09 '22 08:10 hotcodemacha

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 17m 16s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 49s Maven dependency ordering for branch
+1 :green_heart: mvninstall 28m 51s trunk passed
+1 :green_heart: compile 6m 56s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 6m 26s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 34s trunk passed
+1 :green_heart: mvnsite 3m 29s trunk passed
+1 :green_heart: javadoc 2m 31s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 2m 58s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 19s trunk passed
+1 :green_heart: shadedclient 23m 24s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 24s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 38s the patch passed
+1 :green_heart: compile 6m 44s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 6m 44s the patch passed
+1 :green_heart: compile 6m 17s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 6m 17s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 17s hadoop-hdfs-project: The patch generated 0 new + 418 unchanged - 1 fixed = 418 total (was 419)
+1 :green_heart: mvnsite 2m 54s the patch passed
+1 :green_heart: javadoc 2m 2s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 2m 27s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 7m 17s the patch passed
+1 :green_heart: shadedclient 23m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 27s hadoop-hdfs-client in the patch passed.
-1 :x: unit 342m 42s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: unit 8m 31s hadoop-hdfs-httpfs in the patch passed.
+1 :green_heart: asflicense 0m 56s The patch does not generate ASF License warnings.
528m 28s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.ha.TestObserverNode
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/6/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4750
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 75e69096caae 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 91a51924b015789c6a93693a24ebe6eb84c5ece2
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/6/testReport/
Max. process+thread count 2287 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4750/6/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Oct 09 '22 16:10 hadoop-yetus

TestObserverNode failures are not related and didnt fail trying multiple times in local.

Screenshot 2022-10-09 at 18 18 00

hotcodemacha avatar Oct 09 '22 17:10 hotcodemacha

TestObserverNode failures are not related and didnt fail trying multiple times in local.

Screenshot 2022-10-09 at 18 18 00

Yeah, hadoop.hdfs.server.namenode.ha.TestObserverNode also failed in other PRs. And I'm trying to locate the root cause. Just ignore it here.

ZanderXu avatar Oct 10 '22 01:10 ZanderXu

Thanks @ZanderXu for confirming. I have created JIRA for it - HDFS-16801. Please feel to take it over incase you find the root cause. Meanwhile I will also try looking into it. Thanks.

hotcodemacha avatar Oct 10 '22 02:10 hotcodemacha

Many congratulations @ZanderXu for committing a committer :tada: Well deserved and great work. :smiley:

hotcodemacha avatar Oct 12 '22 16:10 hotcodemacha

@ZanderXu - Can we commit/merge this?

hotcodemacha avatar Oct 17 '22 10:10 hotcodemacha

Merged into trunk. Thanks @ashutoshcipher for your contribution.

ZanderXu avatar Oct 17 '22 10:10 ZanderXu