gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-2193] Fail Azkaban job on Temporal Job Failure

Open iPalash opened this issue 9 months ago • 1 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title.
    • https://issues.apache.org/jira/browse/GOBBLIN-2193

Description

  • [x] Here are some details about my PR, including screenshots (if applicable): Currently when the temporal job running on Yarn fails, we don't propagate the error back to Azkaban job which launches the Yarn Application.

The change here bubbles the issues encountered when the job fails upto the GobblinYarnAppLaucher run by the Azkaban job and fails with a RuntimeException after logging the issues summary.

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: Tested manually

Commits

  • [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

iPalash avatar Feb 06 '25 06:02 iPalash

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 51.49%. Comparing base (adef734) to head (ba88388).

Files with missing lines Patch % Lines
...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java 13.33% 13 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4096      +/-   ##
============================================
+ Coverage     45.38%   51.49%   +6.10%     
- Complexity     3192     7566    +4374     
============================================
  Files           696     1388     +692     
  Lines         26628    52198   +25570     
  Branches       2655     5733    +3078     
============================================
+ Hits          12085    26878   +14793     
- Misses        13542    23026    +9484     
- Partials       1001     2294    +1293     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 06 '25 07:02 codecov-commenter