gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-2134] update job status to SKIPPED for all the dependent jobs of a cancelled job

Open arjun4084346 opened this issue 1 year ago • 1 comments

fix merge conflicts add tests

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-2134

Description

  • [x] Here are some details about my PR, including screenshots (if applicable): created SKIPPED execution status used it for the jobs that cannot be run because it's parent job is cancelled

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: updated tests in ReevaluateDagProcTest

Commits

  • [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

arjun4084346 avatar Sep 05 '24 19:09 arjun4084346

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.11%. Comparing base (444f266) to head (8d5589d). Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4049      +/-   ##
============================================
+ Coverage     38.79%   41.11%   +2.31%     
- Complexity     1599     2201     +602     
============================================
  Files           388      480      +92     
  Lines         15998    20360    +4362     
  Branches       1585     2355     +770     
============================================
+ Hits           6207     8371    +2164     
- Misses         9293    11097    +1804     
- Partials        498      892     +394     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 05 '24 19:09 codecov-commenter