flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to g…

Open davidradl opened this issue 1 year ago • 2 comments

Back port of https://github.com/apache/flink/pull/22026 to Flink 1.19.

What is the purpose of the change SqlClient now uses SqlGateway for job submission. It will connect to the gateway's RestServer through the RestClient to interact. when we create the RestClient, we load all the configuration options, but when we create the rest server, we only load the EndpointOptions. As a result, if we want to ensure the security of the connection through SSL, the client will enable SSL, but the server does not. The problem of parameter inconsistency will lead to potential problems in the future. We'd better avoid it directly.

Brief change log Pass all flink parameters to the SqlGatewayRestEndpoint. Verifying this change This change added tests and can be verified by SqlClientSSLTest.

Does this pull request potentially affect one of the following parts: Dependencies (does it add or upgrade a dependency): no The public API, i.e., is any changed class annotated with @public(Evolving): yes The serializers: no The runtime per-record code paths (performance sensitive): no Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no The S3 file system connector: no Documentation Does this pull request introduce a new feature? no

davidradl avatar Apr 29 '24 11:04 davidradl

@reswqa As discussed please could you merge

davidradl avatar Apr 29 '24 11:04 davidradl

CI report:

  • 1a514b14069188434916ae4da176a8cae84e0af4 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Apr 29 '24 11:04 flinkbot

Oops, I just found that the newly introduce method in sql gateway context breaks japicmp's compatibility check.

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=59754&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=13638

I filed a PR hoping to fix it. https://github.com/apache/flink/pull/24831

reswqa avatar May 23 '24 07:05 reswqa