flink-cdc icon indicating copy to clipboard operation
flink-cdc copied to clipboard

[WIP][mysql] Add ExternalSystemListener to notify user about the status of connector.

Open lvyanquan opened this issue 2 years ago • 6 comments

this closes https://github.com/ververica/flink-cdc-connectors/issues/2520

Try to support notification about the status of connector, since it may be a common demand from community. However, I met some problem when add a preliminary implementation, want to get some advice from yours.

  1. When I try to define an enum of ExternalSystemEvent, I found that it's similar to AssignerStatus, can we reuse it?
  2. Should we send information about finished splits to listener? then it would be very similar to checkpoint.
  3. Should we add a default implement like KafkaListener?

lvyanquan avatar Sep 26 '23 08:09 lvyanquan

Hi, @ruanhang1993 Not sure if my design and confusion are reasonable, Looking forward to your advice. 😊

lvyanquan avatar Sep 26 '23 08:09 lvyanquan

@lvyanquan Wow.. First of all, Thank you for implementing this function I was hoping for.

I've been so busy at work and was just about to implement it, but you've already implemented it! 🤣🤣🤣

Can I run this pr with our company in-house notification tools and give you some comment??🙇🏻‍♂️🙇🏻‍♂️

SML0127 avatar Oct 01 '23 07:10 SML0127

@lvyanquan Wow.. First of all, Thank you for implementing this function I was hoping for.

I've been so busy at work and was just about to implement it, but you've already implemented it! 🤣🤣🤣

Can I run this pr with our company in-house notification tools and give you some comment??🙇🏻‍♂️🙇🏻‍♂️

I added some information (e.g. startupMode, gtids) for notification message and created PR.

As our team implemented and used this notification feature, we realized that the startupMode and gtids information was really useful. So I added it.

I hope you give it a try, and thanks for any comments!! 😄🙇🏻‍♂️

SML0127 avatar Oct 01 '23 08:10 SML0127

It makes sense to me, and I create an abstract class AbstractListenerMessage since there are other datasources like oracle、postgreSQL.

lvyanquan avatar Oct 02 '23 07:10 lvyanquan

It makes sense to me, and I create an abstract class AbstractListenerMessage since there are other datasources like oracle、postgreSQL.

LGTM! I learn a lot from your implementation😃

SML0127 avatar Oct 02 '23 16:10 SML0127

Is there any progress on this PR? cc @lvyanquan

yuxiqian avatar Apr 26 '24 05:04 yuxiqian

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

github-actions[bot] avatar Jul 17 '24 00:07 github-actions[bot]