echarts icon indicating copy to clipboard operation
echarts copied to clipboard

Aria omit columns

Open semla opened this issue 1 year ago • 4 comments

Brief Information

This pull request is in the type of:

  • [ ] bug fixing
  • [x] new feature
  • [ ] others

What does this PR do?

Allows omitting columns from the data in aria-label.

Fixed issues

Details

Before: What was the problem?

All data was present in the aria-label. My use case was for a map chart, where the coordinates should be excluded.

After: How does it behave after the fixing?

Add column indexes to be excluded to aria.data.columnsToExclude and they will not appear in the data in aria.label.

Document Info

One of the following should be checked.

  • [ ] This PR doesn't relate to document changes
  • [x] The document should be updated later
  • [ ] The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • [ ] Please squash the commits into a single one when merging.

Other information

semla avatar Jun 17 '24 13:06 semla

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

echarts-bot[bot] avatar Jun 17 '24 13:06 echarts-bot[bot]

Please make this PR "ready for review" when you are ready so that we know it's time for us to review. Thanks!

Ovilia avatar Jun 21 '24 08:06 Ovilia

Is this PR ready for review?

Ovilia avatar Jun 28 '24 11:06 Ovilia

Is this PR ready for review?

I think so

semla avatar Jul 17 '24 10:07 semla

There seems to be a lot of commits included in this PR. Please make sure you merged master correctly.

How about I delete this PR and create a new "clean" one?

semla avatar Jul 29 '24 08:07 semla

Yes, that should be good.

Ovilia avatar Aug 01 '24 06:08 Ovilia

https://github.com/apache/echarts/pull/20218

semla avatar Aug 01 '24 10:08 semla