dubbo-go icon indicating copy to clipboard operation
dubbo-go copied to clipboard

[Performance Tuning]Use NotifyAll instead of Notify one after one on address notification.

Open chickenlj opened this issue 3 years ago • 3 comments

image

Use NotifyAll instead of Notify one after one.

chickenlj avatar Aug 25 '22 03:08 chickenlj

https://github.com/apache/dubbo-go/blob/master/registry/event/service_instances_changed_listener_impl.go#L133

chickenlj avatar Aug 25 '22 03:08 chickenlj

@zhaoyunxing92 you could assign me

thehackercat avatar Aug 26 '22 14:08 thehackercat

@chickenlj I assume Listerner.NotifyAll will solve this https://github.com/apache/dubbo-go/blob/80efe12ab22655da75447970dbca6db28c4b87b3/registry/mocks/NotifyListener.go#L41

will have a try.

thehackercat avatar Aug 28 '22 02:08 thehackercat