drill icon indicating copy to clipboard operation
drill copied to clipboard

Upgrade to Jetty v12

Open aryan26roy opened this issue 11 months ago • 3 comments

Is your feature request related to a problem? Please describe. Apache Drill currently comes with Jetty 9, which is going to hit EOL soon, can the Apache Drill project move to Jetty 12.

aryan26roy avatar Dec 12 '24 11:12 aryan26roy

@aryan26roy I can take a look at this, but my initial experiments are showing that this is not a trivial update.

cgivre avatar Dec 13 '24 16:12 cgivre

@aryan26roy After looking into this, I found the reason we haven't updated. Drill is currently built to support Java versions 8. 11 and 17. Jetty version 12 does not support version 8.
We could certainly discuss dropping Java 8 support, however, for the moment, we're stuck with version 9.4.56.v20240826.

cgivre avatar Dec 24 '24 15:12 cgivre

Jetty 9 (and 10 and 11) just went EOL yesterday. I'm not sure why this issue is closed?

qwertychouskie avatar Jan 03 '25 01:01 qwertychouskie

You can maintain the javax.servlet. support on Jetty 12 by using the ee8 environment, which still supports the legacy servlet namespace.

joakime avatar Nov 08 '25 14:11 joakime

Be aware of the changes to EOL versions of Jetty.

  • https://github.com/jetty/jetty.project/discussions/13984

joakime avatar Nov 08 '25 14:11 joakime

@joakime @aryan26roy @qwertychouskie I've been working on migrating Drill to a newer version of Jetty and let's just start with it is not easy. A big issue with this also is the Java support. For the moment, Drill supports java 11 as the minimum Java version. I would, of course, like to update to the latest version, however it would also require dropping support for Java 11.

What are your thoughts on the matter?

cgivre avatar Nov 09 '25 15:11 cgivre

Most OpenJDK vendors ended Java 11 support at the end of 2024. Why are you supporting a JVM that isn't supported by the JVM vendor itself?

Most OpenJDK vendors will not release security fixes for Java 11 publicly anymore, only those that pay for extended support get access to those fixes.

joakime avatar Nov 09 '25 15:11 joakime

@joakime @qwertychouskie @aryan26roy I just submitted a pull request with this update. Would one of you be able to review it?

cgivre avatar Nov 10 '25 02:11 cgivre

@cgivre I'll be able to review it this week.

joakime avatar Nov 10 '25 16:11 joakime

@joakime Thanks! All unit tests are now passing. I had to modify a lot of files, but really a lot of it was just updating imports.

cgivre avatar Nov 10 '25 16:11 cgivre