drill icon indicating copy to clipboard operation
drill copied to clipboard

Published 20 hours ago • verified publisher icon apache

DRILL-8180: Add Icons to Storage Plugin List

Open cgivre opened this issue 3 years ago • 4 comments

DRILL-8180: Add Icons to Storage Plugin List

Description

Documentation

This PR adds icons to the storage plugin list depending on the type of storage plugin. See screenshot below.

Screen Shot 2022-03-28 at 3 56 36 PM

The logo gets its name from the plugin config file. So a plugin FooStoragePluginConfig would be required to provide an icon of approx 40px x 40px called Foo.png.

Testing

Tested manually

cgivre avatar Mar 28 '22 19:03 cgivre

Nice touch. I see we don't always have transparent backgrounds and sometimes we have a visible block behind the rendered icon. Let me know if I can help out here by hitting them with the GIMP.

jnturton avatar Mar 29 '22 09:03 jnturton

Nice touch. I see we don't always have transparent backgrounds and sometimes we have a visible block behind the rendered icon. Let me know if I can help out here by hitting them with the GIMP.

I would really appreciate that. I don't actually have image editing software on my machine, or experience with the GIMP. Also, if you don't like any of the icons, feel free to change.

cgivre avatar Mar 29 '22 12:03 cgivre

Is it possible to add plugin pictures to specific storage plugin folders instead of adding it to the java-exec module?

I suppose so, but I'm not quite sure how you would do that. All the Drill REST server components (to include static resources) are contained in java-exec. Any ideas?

cgivre avatar Mar 29 '22 13:03 cgivre

When running java application, resources from all places that are in class path should be accessible.

vvysotskyi avatar Mar 29 '22 13:03 vvysotskyi