drill icon indicating copy to clipboard operation
drill copied to clipboard

DRILL-7169: Rename drill-root ArtifactID to apache-drill

Open vdiravka opened this issue 6 years ago • 4 comments

Change 'project.artifactId' from 'drill-root' to 'apache-drill'

Note: it includes changes for #1743 also (it is expected that PR will be merged first)

vdiravka avatar Apr 11 '19 18:04 vdiravka

@vdiravka, with this change, a folder with the unpacked build in distribution was renamed from apache-drill-1.16.0-SNAPSHOT to distribution-1.16.0-SNAPSHOT, so for now built version is in the distribution/target/distribution-1.16.0-SNAPSHOT/distribution-1.16.0-SNAPSHOT/ instead of distribution/target/apache-drill-1.16.0-SNAPSHOT/apache-drill-1.16.0-SNAPSHOT/.

I don't think that we should rename these folders.

Thanks for finding this, it is random mistake.

vdiravka avatar Apr 12 '19 11:04 vdiravka

@vvysotskyi @sohami I have rebased the changes onto latest Drill master branch and added one commit with minor improvement. Please review it, once the community will agreed in dev mailing list with these changes: Note: mail topic is Rename 'project.artifactId'

vdiravka avatar May 08 '19 21:05 vdiravka

@vdiravka / @vvysotskyi what is the status of this PR?

arina-ielchiieva avatar Jun 03 '19 07:06 arina-ielchiieva

Currently, there is no consensus for this change, here is mail thread with the discussion: https://lists.apache.org/thread.html/99a2098ae04d56dd5994288b5fc05780d7de09a2f4a5ffbc5ce39cde@%3Cdev.drill.apache.org%3E

vvysotskyi avatar Jun 03 '19 09:06 vvysotskyi