doris icon indicating copy to clipboard operation
doris copied to clipboard

Published 20 hours ago • verified publisher icon apache

[Enchancement](sort) refactor of SortingQueueImpl::update_batch_size / MergeSortCursorImpl::reverse

Open BiteTheDDDDt opened this issue 5 months ago • 8 comments

What problem does this PR solve?

  1. refactor of SortingQueueImpl::update_batch_size
  2. optmization of MergeSortCursorImpl::reverse

Check List (For Author)

  • Test

    • [ ] Regression test
    • [ ] Unit Test
    • [ ] Manual test (add detailed scripts or steps below)
    • [ ] No need to test or manual test. Explain why:
      • [ ] This is a refactor/code format and no logic has been changed.
      • [ ] Previous test can cover this change.
      • [ ] No code files have been changed.
      • [ ] Other reason

  • Behavior changed:

    • [ ] No.
    • [ ] Yes.

  • Does this need documentation?

    • [ ] No.
    • [ ] Yes.

Check List (For Reviewer who merge this PR)

  • [ ] Confirm the release note
  • [ ] Confirm test cases
  • [ ] Confirm document
  • [ ] Add branch pick label

BiteTheDDDDt avatar Jun 17 '25 07:06 BiteTheDDDDt

run buildall

BiteTheDDDDt avatar Jun 17 '25 07:06 BiteTheDDDDt

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

hello-stephen avatar Jun 17 '25 07:06 hello-stephen

run buildall

BiteTheDDDDt avatar Jun 18 '25 02:06 BiteTheDDDDt

run buildall

BiteTheDDDDt avatar Jun 18 '25 03:06 BiteTheDDDDt

run buildall

BiteTheDDDDt avatar Jun 18 '25 09:06 BiteTheDDDDt

run buildall

BiteTheDDDDt avatar Jun 18 '25 10:06 BiteTheDDDDt

run buildall

BiteTheDDDDt avatar Jun 18 '25 12:06 BiteTheDDDDt

run buildall

BiteTheDDDDt avatar Jun 18 '25 12:06 BiteTheDDDDt

run buildall

BiteTheDDDDt avatar Jun 19 '25 16:06 BiteTheDDDDt

BE Regression && UT Coverage Report

Increment line coverage 68.25% (43/63) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 61.31% (16112/26281)
Line Coverage 50.81% (151552/298255)
Region Coverage 48.21% (86761/179967)
Branch Coverage 41.57% (42504/102250)

hello-stephen avatar Jun 19 '25 20:06 hello-stephen

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Jun 20 '25 02:06 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Jun 20 '25 02:06 github-actions[bot]