doris icon indicating copy to clipboard operation
doris copied to clipboard

Published 20 hours ago • verified publisher icon apache

branch-3.0: [fix](broker) BE crashed because of empty broker #51274

Open github-actions[bot] opened this issue 5 months ago • 6 comments

Cherry-picked from #51274

github-actions[bot] avatar Jun 17 '25 03:06 github-actions[bot]

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

hello-stephen avatar Jun 17 '25 03:06 hello-stephen

run buildall

hello-stephen avatar Jun 17 '25 03:06 hello-stephen

BE UT Coverage Report

Increment line coverage 0.00% (0/35) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 41.17% (10896/26463)
Line Coverage 31.99% (93208/291351)
Region Coverage 31.06% (48079/154782)
Branch Coverage 27.54% (24635/89458)

doris-robot avatar Jun 17 '25 04:06 doris-robot

should merge this pr: https://github.com/apache/doris/pull/51243 at first, need BrokerMgr.getBrokers function

cambyzju avatar Jun 18 '25 11:06 cambyzju

run buildall

cambyzju avatar Jun 18 '25 12:06 cambyzju

BE UT Coverage Report

Increment line coverage 0.00% (0/35) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 41.16% (10902/26488)
Line Coverage 31.96% (93225/291728)
Region Coverage 31.04% (48081/154916)
Branch Coverage 27.50% (24627/89540)

doris-robot avatar Jun 18 '25 14:06 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Jun 20 '25 01:06 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Jun 20 '25 01:06 github-actions[bot]

run buildall

cambyzju avatar Jun 20 '25 06:06 cambyzju

BE UT Coverage Report

Increment line coverage 0.00% (0/35) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 41.15% (10903/26494)
Line Coverage 31.96% (93300/291941)
Region Coverage 31.03% (48100/155015)
Branch Coverage 27.50% (24642/89620)

doris-robot avatar Jun 20 '25 07:06 doris-robot

run buildall

cambyzju avatar Jun 23 '25 02:06 cambyzju

BE UT Coverage Report

Increment line coverage 0.00% (0/35) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 41.17% (10911/26503)
Line Coverage 31.99% (93408/292035)
Region Coverage 31.05% (48140/155058)
Branch Coverage 27.51% (24660/89648)

doris-robot avatar Jun 23 '25 03:06 doris-robot

run buildall

cambyzju avatar Jun 23 '25 08:06 cambyzju

TPC-H: Total hot run time: 39757 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d5423714f033faf40ea9fa824d2f71e407e9ce38, data reload: false

------ Round 1 ----------------------------------
q1	17615	7010	6671	6671
q2	2069	171	168	168
q3	10694	1110	1180	1110
q4	10428	714	717	714
q5	7744	2882	2859	2859
q6	217	137	132	132
q7	967	628	600	600
q8	9369	1950	2047	1950
q9	6568	6420	6410	6410
q10	7030	2293	2278	2278
q11	466	256	257	256
q12	396	209	210	209
q13	17762	2986	3023	2986
q14	234	203	217	203
q15	501	465	456	456
q16	485	376	391	376
q17	998	509	496	496
q18	7322	6724	6586	6586
q19	1403	1133	1055	1055
q20	486	209	200	200
q21	4146	3059	3205	3059
q22	1088	1017	983	983
Total cold run time: 107988 ms
Total hot run time: 39757 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6623	7294	6578	6578
q2	326	231	234	231
q3	2943	2827	2970	2827
q4	2133	1809	1789	1789
q5	5773	5770	5706	5706
q6	218	131	136	131
q7	2236	1842	1822	1822
q8	3390	3565	3554	3554
q9	8933	8884	8913	8884
q10	3606	3557	3526	3526
q11	606	504	509	504
q12	876	611	637	611
q13	9630	3182	3129	3129
q14	310	281	272	272
q15	506	472	476	472
q16	488	440	440	440
q17	1840	1626	1646	1626
q18	8170	7764	7748	7748
q19	1708	1610	1568	1568
q20	2049	1847	1822	1822
q21	5250	5035	5100	5035
q22	1110	1026	1041	1026
Total cold run time: 68724 ms
Total hot run time: 59301 ms

doris-robot avatar Jun 23 '25 08:06 doris-robot

TPC-DS: Total hot run time: 196659 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d5423714f033faf40ea9fa824d2f71e407e9ce38, data reload: false

query1	1275	911	912	911
query2	6360	1909	1882	1882
query3	10843	4297	4288	4288
query4	60831	28787	23920	23920
query5	5291	472	459	459
query6	397	184	198	184
query7	5482	317	312	312
query8	309	228	221	221
query9	8495	2605	2604	2604
query10	479	275	265	265
query11	17849	15022	15609	15022
query12	166	107	104	104
query13	1472	470	427	427
query14	9849	6765	7370	6765
query15	198	178	174	174
query16	7126	471	467	467
query17	1277	587	607	587
query18	1900	337	321	321
query19	221	162	162	162
query20	120	112	110	110
query21	210	100	105	100
query22	4679	4549	4552	4549
query23	34535	34029	34427	34029
query24	6435	3004	2961	2961
query25	594	446	455	446
query26	700	170	172	170
query27	2020	354	355	354
query28	4328	2204	2164	2164
query29	737	489	470	470
query30	238	159	160	159
query31	1016	834	845	834
query32	71	61	66	61
query33	430	318	321	318
query34	952	542	539	539
query35	839	749	749	749
query36	1077	938	920	920
query37	118	82	68	68
query38	4043	3963	3928	3928
query39	1516	1474	1446	1446
query40	206	98	97	97
query41	51	49	47	47
query42	113	106	100	100
query43	512	478	475	475
query44	1242	841	844	841
query45	185	170	167	167
query46	1146	744	736	736
query47	1986	1910	1916	1910
query48	479	392	390	390
query49	752	411	399	399
query50	858	428	431	428
query51	7463	7298	7274	7274
query52	102	102	91	91
query53	258	189	191	189
query54	590	464	476	464
query55	75	81	79	79
query56	292	259	236	236
query57	1307	1194	1203	1194
query58	237	215	227	215
query59	3116	2939	2796	2796
query60	290	260	250	250
query61	111	110	117	110
query62	785	686	673	673
query63	213	191	190	190
query64	2389	666	618	618
query65	3264	3183	3164	3164
query66	758	300	301	300
query67	15866	15402	15655	15402
query68	4281	593	592	592
query69	447	276	260	260
query70	1202	1085	1096	1085
query71	324	274	260	260
query72	6389	4130	4001	4001
query73	776	352	367	352
query74	10513	8964	9202	8964
query75	3338	2665	2640	2640
query76	2037	1073	1124	1073
query77	479	277	277	277
query78	10709	9547	9514	9514
query79	1552	588	606	588
query80	882	440	445	440
query81	492	225	219	219
query82	1218	90	88	88
query83	244	145	146	145
query84	281	79	78	78
query85	889	313	292	292
query86	325	297	287	287
query87	4381	4190	4223	4190
query88	3751	2422	2379	2379
query89	406	291	284	284
query90	2036	189	185	185
query91	176	150	146	146
query92	65	49	50	49
query93	1881	558	556	556
query94	747	313	301	301
query95	353	254	258	254
query96	616	278	276	276
query97	3279	3110	3125	3110
query98	221	196	190	190
query99	1615	1306	1299	1299
Total cold run time: 315029 ms
Total hot run time: 196659 ms

doris-robot avatar Jun 23 '25 08:06 doris-robot

BE UT Coverage Report

Increment line coverage 0.00% (0/35) :tada:

Increment coverage report Complete coverage report

Category Coverage
Function Coverage 41.17% (10912/26503)
Line Coverage 31.99% (93410/292035)
Region Coverage 31.05% (48149/155058)
Branch Coverage 27.51% (24663/89648)

hello-stephen avatar Jun 23 '25 08:06 hello-stephen

ClickBench: Total hot run time: 29.97 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d5423714f033faf40ea9fa824d2f71e407e9ce38, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.61	0.11	0.10
query5	0.52	0.53	0.52
query6	1.13	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.56	0.50	0.50
query10	0.54	0.55	0.58
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	0.78	0.78	0.80
query15	0.85	0.83	0.83
query16	0.38	0.38	0.36
query17	1.01	1.02	1.05
query18	0.23	0.21	0.22
query19	1.97	1.81	1.86
query20	0.01	0.01	0.00
query21	15.39	0.58	0.58
query22	2.39	1.64	2.18
query23	17.01	0.98	0.85
query24	3.05	1.64	0.99
query25	0.17	0.10	0.04
query26	0.61	0.14	0.14
query27	0.04	0.04	0.04
query28	9.93	0.46	0.50
query29	12.57	3.26	3.25
query30	0.25	0.06	0.06
query31	2.85	0.39	0.36
query32	3.24	0.48	0.46
query33	2.95	2.99	3.03
query34	17.11	4.46	4.44
query35	4.58	4.50	4.51
query36	0.67	0.47	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.18 s
Total hot run time: 29.97 s

doris-robot avatar Jun 23 '25 08:06 doris-robot