doris icon indicating copy to clipboard operation
doris copied to clipboard

[improvement](jdbc catalog) Disallow non-constant type conversion pushdown and implicit conversion pushdown

Open zy-kkk opened this issue 1 year ago • 2 comments

Add a variable jdbc_cast_expr_pushdown, the default value is false, which prohibits the pushdown of non-constant predicates with type conversion and all predicates with implicit conversion. This change can prevent the wrong predicates from being pushed down to the Jdbc data source, resulting in query data errors, because the predicates with cast were not correctly pushed down to the data source before. If you find that the data is read correctly and the performance is better before this change, you can manually set this variable to true

| Expression                                          | Can Push Down |
|-----------------------------------------------------|---------------|
| column type equals const type                       | Yes           |
| column type equals cast const type                  | Yes           |
| cast column type equals const type                  | No            |
| cast column type equals cast const type             | No            |
| column type not equals column type                  | No            |
| column type not equals cast const type              | No            |
| cast column type not equals const type              | No            |
| cast column type not equals cast const type         | No            |

zy-kkk avatar Oct 18 '24 10:10 zy-kkk

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar Oct 18 '24 10:10 doris-robot

run buildall

zy-kkk avatar Oct 18 '24 10:10 zy-kkk

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Oct 21 '24 15:10 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Oct 21 '24 15:10 github-actions[bot]

run buildall

morningman avatar Oct 21 '24 15:10 morningman

run buildall

zy-kkk avatar Oct 22 '24 03:10 zy-kkk

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Oct 22 '24 06:10 github-actions[bot]